Skip to content

Conversation

BreadGenie
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021

Codecov Report

Merging #1235 (b2949ae) into main (72a59f5) will decrease coverage by 2.01%.
The diff coverage is 15.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1235      +/-   ##
==========================================
- Coverage   78.36%   76.35%   -2.02%     
==========================================
  Files         223      223              
  Lines        4368     4385      +17     
  Branches      549      553       +4     
==========================================
- Hits         3423     3348      -75     
- Misses        809      893      +84     
- Partials      136      144       +8     
Flag Coverage Δ
longtests 76.35% <15.00%> (-2.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/package_list_parser/__init__.py 70.58% <15.00%> (-10.79%) ⬇️
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (-27.28%) ⬇️
test/test_json.py 68.96% <0.00%> (-20.69%) ⬇️
test/test_scanner.py 61.71% <0.00%> (-12.50%) ⬇️
test/test_cli.py 81.28% <0.00%> (-11.83%) ⬇️
cve_bin_tool/checkers/systemd.py 85.18% <0.00%> (-7.41%) ⬇️
cve_bin_tool/version.py 70.00% <0.00%> (-5.00%) ⬇️
cve_bin_tool/checkers/glibc.py 96.29% <0.00%> (-3.71%) ⬇️
cve_bin_tool/cli.py 75.15% <0.00%> (-3.04%) ⬇️
cve_bin_tool/cvedb.py 85.01% <0.00%> (-2.29%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a59f5...b2949ae. Read the comment docs.

else:
# TODO: Replace below error handling with a proper pip install dry run
# See: https://github.com/pypa/pip/issues/53
with ErrorHandler(mode=error_mode):
raise InvalidListError("Invalid Python Package list")
raise InvalidListError("Invalid Package list")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a way for the user to see on the command line which package managers are supported? That might be a good future feature.

@terriko terriko merged commit f57e710 into intel:main Jul 14, 2021
@BreadGenie BreadGenie deleted the pacman-support branch July 14, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants