fix(security): add noreferer in target=_blank inside html reports #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
- Coverage 78.36% 76.62% -1.74%
==========================================
Files 223 223
Lines 4368 4368
Branches 549 549
==========================================
- Hits 3423 3347 -76
- Misses 809 877 +68
- Partials 136 144 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
terriko
requested changes
Jul 13, 2021
| @@ -71,7 +71,7 @@ <h4 class="alert-heading"><strong> | |||
| <hr> | |||
| <p class="mb-0">For more help on how to enable JavaScript. Click <a | |||
| href="https://www.tutorialspoint.com/javascript/javascript_enabling.htm" class="alert-link" | |||
| target="_blank">here</a></p> | |||
| target="_blank" rel="noopener noreferrer" rel="noopener noreferrer">here</a></p> | |||
There was a problem hiding this comment.
Looks like rel got duplicated here.
terriko
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rules.sonarsource.com/html/RSPEC-5148