Skip to content

Horizon Core Changes #5 #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 24, 2025
Merged

Horizon Core Changes #5 #3517

merged 6 commits into from
Jul 24, 2025

Conversation

szabinst
Copy link
Collaborator

[ignore-commit-lint]
affects: Student, Teacher, Parent

@szabinst
Horizon Core Changes #5
a584fe7 
[ignore-commit-lint]
affects: Student, Teacher, Parent
@szabinst szabinst self-assigned this Jul 21, 2025
@inst-danger
Copy link
Contributor

inst-danger commented Jul 21, 2025 •
edited
Loading

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jul 21, 2025 •
edited
Loading

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jul 21, 2025 •
edited
Loading

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jul 21, 2025 •
edited
Loading

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.24% 91.37% -0.13%
Core/Core/Common/CommonUI/CoreWebView/View/CoreWebViewAccessibilityHelper.swift 0% 0% 0%
Student/Student/WidgetRouting/WidgetRouter+GradeListWidget.swift 0% 0% 0%

Generated by 🚫 dangerJS against aeb515f

@szabinst szabinst marked this pull request as ready for review July 22, 2025 09:00
suhaibabsi-inst
suhaibabsi-inst reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szabinst !
Generally looks good to me, few comments for you to consider.

@szabinst szabinst requested a review from suhaibabsi-inst July 23, 2025 07:39
suhaibabsi-inst
suhaibabsi-inst approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

rh12
rh12 approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@szabinst szabinst merged commit 1ade88b into master Jul 24, 2025
6 checks passed
@szabinst szabinst deleted the feature/horizon-core-changes-5 branch July 24, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rh12 rh12 rh12 approved these changes

@suhaibabsi-inst suhaibabsi-inst suhaibabsi-inst approved these changes

@ktheory ktheory Awaiting requested review from ktheory ktheory is a code owner

@JacksonHowe JacksonHowe Awaiting requested review from JacksonHowe JacksonHowe is a code owner

@Ahmed-Naguib93 Ahmed-Naguib93 Awaiting requested review from Ahmed-Naguib93 Ahmed-Naguib93 is a code owner

@reabbotted reabbotted Awaiting requested review from reabbotted reabbotted is a code owner

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz is a code owner

Assignees

@szabinst szabinst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szabinst @inst-danger @rh12 @suhaibabsi-inst