Skip to content

[Horizon] Add View Attempts for Assignments #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

[Horizon] Add View Attempts for Assignments #3452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c04dcf0
feat: add view attempts for assignments
Ahmed-Naguib93 Jun 19, 2025
1eb09d4
fix: showing view Attempts
Ahmed-Naguib93 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Horizon/Horizon/Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,9 @@
},
"View your progress and scores on the Learn page." : {

},
"VIEWING ATTEMPT" : {

},
"Vilnius (+02:00/+03:00)" : {

Expand Down
17 changes: 16 additions & 1 deletion ...ources/Features/LearningObjects/Assignment/AssignmentDetails/View/AssignmentDetails.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@ struct AssignmentDetails: View {
var body: some View {
ScrollViewReader { proxy in
ScrollView(showsIndicators: false) {
if let submission = viewModel.submission, viewModel.shouldShowViewAttempts {
viewAttemptText(attempt: submission.attempt)
}
topView
VStack(spacing: .huiSpaces.space24) {
topView
startQuizButton
introView
.id(viewModel.courseID)
Expand Down Expand Up @@ -81,6 +84,18 @@ struct AssignmentDetails: View {
}
}

private func viewAttemptText(attempt: Int) -> some View {
HStack(spacing: .huiSpaces.space2) {
Text("VIEWING ATTEMPT", bundle: .horizon)
Text(attempt.description)
}
.frame(maxWidth: .infinity)
.padding(.vertical, .huiSpaces.space8)
.foregroundStyle(Color.huiColors.surface.institution)
.background(Color.huiColors.surface.pagePrimary)
.huiTypography(.p2)
}

@ViewBuilder
private func mainContentView(proxy: ScrollViewProxy) -> some View {
if let submission = viewModel.submission, viewModel.hasSubmittedBefore {
Expand Down
2 changes: 2 additions & 0 deletions ...atures/LearningObjects/Assignment/AssignmentDetails/View/AssignmentDetailsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ final class AssignmentDetailsViewModel {
private(set) var selectedSubmission: AssignmentSubmissionType = .text
private(set) var externalURL: URL?
private(set) var submissionProperties: SubmissionProperties?
private(set) var shouldShowViewAttempts = false
var isStartTyping = false
var assignmentPreference: AssignmentPreferenceKeyType?
var isSubmitButtonHidden: Bool {
Expand Down Expand Up @@ -169,6 +170,7 @@ final class AssignmentDetailsViewModel {
}
hasSubmittedBefore = true
submission = selectedSubmission
shouldShowViewAttempts = selectedSubmission != submissions.first
submissionProperties?.hasUnreadComments = hasUnreadComments(for: selectedSubmission?.attempt)
didLoadAssignment(submissionProperties)
}
Expand Down