Skip to content

[Horizon] Remove Chips From Answer Prompt in Assist #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

[Horizon] Remove Chips From Answer Prompt in Assist #3392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28eee94
Making it so the string replacement from instructure.com to canvasfor…
reabbotted May 21, 2025
84f8452
Removing chip generation from the business rules since the business s…
reabbotted May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Core/Core/Common/Extensions/Foundation/URLExtensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,10 @@ public extension URL {

public extension String {
func replaceHostWithCanvasForCareer() -> String {
replacing("pd.instructure.com", with: "pd.canvasforcareer.com")
.replacing("intelvio.instructure.com", with: "intelvio.canvasforcareer.com")
.replacing("horizon.cd.instructure.com", with: "dev.cd.canvashorizon.com")
let newString = replacing("horizon.cd.instructure.com", with: "dev.cd.canvashorizon.com")
if let range = newString.range(of: "instructure.com") {
return newString.replacingCharacters(in: range, with: "canvasforcareer.com")
}
return newString
}
}
13 changes: 0 additions & 13 deletions Horizon/Horizon/Sources/Features/Assist/AssistChat/Domain/AssistChatInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,19 +355,6 @@ class AssistChatInteractorLive: AssistChatInteractor {
return
chatMethod
.map { AssistChatResponse(message: AssistChatMessage(botResponse: $0), chatHistory: history) }
.flatMap { [weak self] response in
guard let self = self else {
return Empty<AssistChatResponse, Error>(completeImmediately: true).eraseToAnyPublisher()
}
return self.chipGenerator(history: response.chatHistory, pageContext: pageContext)
.map { chipOptions in
AssistChatResponse(
chipOptions: chipOptions,
chatHistory: response.chatHistory
)
}
.eraseToAnyPublisher()
}
.eraseToAnyPublisher()
case .flashcards:
return flashcards(
Expand Down