[Horizon] Fixed progress bar issues #3301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ignore-commit-lint]
Ahmed-Naguib93
requested review from
szabinst,
ktheory,
JacksonHowe and
reabbotted
as code owners
|
Horizon Build QR Code: |
szabinst
requested changes
Apr 9, 2025
szabinst
approved these changes
Apr 10, 2025
Ahmed-Naguib93
deleted the
feature/horizon-CLX-1047-Course-progress-indicator-looks-glitched
branch
reabbotted
added a commit
that referenced
this pull request
Aug 21, 2025
* [Horizon] - Add routing to Files, Quizzes (#2942) [ignore-commit-lint] * [Horizon] - Merge master (#2949) [ignore-commit-lint] * [Horizon] Inbox (#2947) [ignore-commit-lint] * [Horizon] Assignment Details (#2950) [ignore-commit-lint] * [Horizon] External url and tool routing (#2954) [ignore-commit-lint] * [Horizon] Add course progress bar (#2951) [ignore-commit-lint] * [Horizon] Assignment details text entry and files upload submission (#2959) * Extend routing from program details [ignore-commit-lint] * fix: lint * Add text entry for assignment details * Fix scrollview issue * feat: Add file upload [ignore-commit-lint] * Enhance the code style [ignore-commit-lint] * Use Bindable in place if state * [Horizon] Add Bottom AI components & AI Tutor & tab bar & ChatBot (#2972) * feat: Bottom AI components & AI Tutor & tab bar & ChatBot [ignore-commit-lint] * Update CI [ignore-commit-lint] * Fix swiftlint issue * Enhance the code style [ignore-commit-lint] * Rename image chatBot * Solve conflicts [ignore-commit-lint] * Fix conflicts * Fix colors * Update yarn --------- Co-authored-by: szabinst <[email protected]> * [Horizon] Dashboard top nav bar (#2974) [ignore-commit-lint] * [Horizon] - Merge master (#2975) [ignore-commit-lint] * [Horizon] Module navigation view (#2981) [ignore-commit-lint] * [Horizon] Fix tab bar on SE size (#2982) * Fix tab bar issue [ignore-commit-lint] * Fix padding in tab bar * Fix naming * Fix chabot button size in tab bar * Rename property * [Horizon] Ai quiz design (#2980) * Feat: Ai quiz [ignore-commit-lint] * Fix navigation bar issue * Fix issues in review * [Horizon] Design System Foundations (#2992) * [Horizon] Flash Card Design (#2988) [ignore-commit-lint] * [Horizon] Merge master (#2993) [ignore-commit-lint] * [Horizon] Fonts (#2998) [ignore-commit-lint] * [Horizon] Add completion checkmark (#2997) * feat: Add completion checkmark [ignore-commit-lint] * Remove unneeded code * Remove unneeded code * Typography variants (#3001) [ignore-commit-lint] * [Horizon] Add Notebook List (#2995) [ignore-commit-lint] * [Horizon] Spaces and Corner Radius levels (#3003) [ignore-commit-lint] * [Horizon] Merge master (#3004) * [Horizon] Add text entry submission modal (#3005) * Move TextSubmissionViewController to core * Elevation levels (#3011) [ignore-commit-lint] * [Horizon] Program Details update (#3006) [ignore-commit-lint] * Border levels (#3012) [ignore-commit-lint] * [Horizon] Add color variants (#3013) * Letter spacing (#3019) [ignore-commit-lint] * Pill component, update border usage (#3018) [ignore-commit-lint] * [Horizon] Edit notebook notes (#3014) [ignore-commit-lint] * [Horizon] Export Material Icons (#3020) [ignore-commit-lint] * [Horizon] Button styles (#3015) [Horizon] Adding the button components * [Horizon] Spinner Component (#3022) * [Horizon] Tooltip (#3026) * [Horizon] Add progress bar (#3028) * [Horizon] Tag component (#3029) * [Horizon] Update Pill component (#3031) * [Horizon] Add badge (#3032) * [Horizon] Merge master (#3035) Update from master * feat: Update tab bat icons (#3037) * [Horizon] Add navigation bar (#3034) Add navigation bar for dashBoard * Fix issue in tab bar (#3052) * [Horizon] Update dashboard & add LearningObjectCard component (#3039) * [Horizon] Icon Buttons (#3036) * [Horizon] Add Controllers (#3047) * [Horizon] Update CourseDetails screen (#3044) * [Horizon] Update courseDetails version 2 (#3054) * [Horizon] Module Sequence View (#3076) * [Horizon] Highlighting and Annotating Text (#3072) * [Horizon] Connect to AI Service (#3077) * [Horizon] Merge master (#3081) * [Horizon] Update from master (#3092) * [Horizon] Intro Block Card (#3090) * [Horizon] Course progress (#3101) * [Horizon] Account screen (#3105) * [Horizon] External Tool Loading (#3104) * [Horizon] External URL Module Handling (#3108) * [Horizon] Pinned the moduleNavBarButtons to the bottom. (#3110) * [ignore-commit-lint] Adding an AccountNavigationBar (#3113) * [Horizon] Using the course progression graphql endpoint (#3100) * Updating the GetCourseProgressionUseCase to use a graphql endpoint for fetching all data * Mapping the GetCourseProgressionResponse coming back from the GraphQL endpoint to the CDCourseProgression core data model. Still need to then map the CDCourseProgression to the HCourse * Hooked up and building * Fixing an issue where the progress bar was going beyond what it was meant * Fixing the tab view to update when the tab changes * Discovered that the course progression graphql endpoint doesn't give us all the information we need for the modules, so reverting back to also pulling in the modules from the rest api * Code cleanup * Satisfying swiftlint * Addressing swiftlint * Fixing an issue with deserialization where a variable name change broke it * Making the createdAt property optional in GetCourseProgressionResponse * Making sure the GetCoursesProgressionRequest requests the module items associated with the incomplete modules * Fixing a bug where the incomplete items are not being transferred correctly within the interactor * Adding in more data loading for the incomplete module items * Sneaking in changing the color for the red text button type * [Horizon] Download file learning object (#3116) * [Horizon] Add Institution color (#3127) * [Horizon] Add FileDrop Uploader (#3120) * [Horizon] Add AlertToast (#3133) * iOS Profile Settings and Advanced (#3135) * [Horizon] Notification settings (#3158) * [Horizon] Merge master (#3159) * [Horizon] Add drop & upload files (#3150) * [Horizon] Segmented control (#3160) * fix: network issue (#3167) [ignore-commit-lint] * [Horizon] Create Modal UI (#3166) * Updating the Info.plist to satisfy testflight and adding a stand-in app icon (#3178) * Trying again to get the app icons (#3179) * [Horizon] Submission Comment View (#3180) * [Horizon] Merge master (#3181) * [Horizon] Update Assignment Details (#3196) * [Horizon] Scores pt1 (#3203) * [Horizon] Dismiss My Progress on selection (#3213) * [Horizon] Expand My Progress page by default (#3214) * [Horizon] Add estimated time (#3218) * [Horizon] Scores pt2 (#3216) * [Horizon] - Notebook (#3205) * [Horizon] Fix toast ui issue (#3226) * [Horizon] Updated color palette (#3231) * [Horizon] User agent (#3232) * [Horizon] Integrate Inbox & Skill Space web view (#3235) * [Horizon] Fix overview, course details tab lag (#3237) * [Horizon] Disable dark mode (#3238) * [Horizon] Change app to Canvas Career (#3240) * [Horizon] Reorganize folders (#3239) * [Horizon] Merge master (#3241) * [Horizon] Quiz (#3242) * fix: score assignment navigation (#3243) * [Horizon] Fix dashborad Caching (#3248) * [Horizon] Add mark as done button in pages (#3251) * [Horizon] Assist Feature (#3247) * [Horizon] Updating the SingleSelect Component (#3252) * [Horizon] Fix XCConfig (#3261) * [Horizon] Notification (#3262) * [Horizon] Fix dashboard loading issue (#3265) * [Horizon] Merge master (#3266) * [Horizon] Inbox - Conversations details double back button (#3269) * [Horizon] PKCE Login (#3281) * [Horizon] Notebook Design Review Updates (#3282) * Adding an elevation to the notebook close and back buttons * UI updates * Adjusting icon button sizes in some places now that the small size is smaller * Removing the cancel button from the notebook note page. * More UI styling updates to the notebook. also opening the notebook as a modal from a course module * Addressing merge request comments * Fixing the time zone not getting loaded and saved correctly in the advanced settings [ignore-commit-lint] (#3284) * Making it so if a submission type is none, then the button is not shown for submitting (#3285) * [Horizon] Display Course Score (#3289) * [Horizon] CLX-1039 Refresh course details upon module completion (#3293) * [Horizon] Fixed Assignment Issues (#3297) * [Horizon] File Upload Loading Indicator is Duplicated (#3296) * [Horizon] Merge master (#3300) * [Horizon] Pendo Integration (#3302) * [Horizon] Fixed progress bar issues (#3301) * Fixing notebook view for embedding * [Horizon] Crashlytics integration (#3303) * [Horizon] Course Scoring Update (#3307) * [Horizon ]Add learn tab (#3308) * fix: ui issues (#3316) * [Horizon] Merge master (#3318) * [Horizon] Fixing Notebook Syncing (#3306) * [Horizon] Renaming some font cases (#3325) * [Horizon] iOS Course List Discrepancy with Web (#3326) * Making it so we only download the Horizon courses. This GraphQL call now matches what the web is doing [ignore-commit-lint] * Making it so i can specify to the GetCoursesProgressionRequest if we only want horizon courses * [Horizon] Add invitation course (#3320) * [Horizon] Interim Inbox and Skillspace Pages (#3319) * Adding the interim skillspace and inbox pages letting the user know they'll need to log in on a browser. [ignore-commit-lint] * Adding files that were missed previously * Fixing the loading of Figtree Regular * [Horizon] Update course progress after submit quiz (#3327) * [Horizon] Account Menu Item Updates (#3329) * feat: add empty view for scores (#3333) * [Horizon] Fetch first moduleItem in case incomplete module is empty in dashboard (#3337) * [Horizon] Notebook not navigating the module item correctly (#3338) * feat: Add webView font (#3340) [ignore-commit-lint] * Hiding the previous/next page buttons in the notebook if there are no other pages. [ignore-commit-lint] (#3347) * Changing up the styling for the highlighted text in the notebook when there are multiple lines. Also fixing up some of the javascript web highlighting.[ignore-commit-lint] (#3346) * [Horizon] Use GraphQL for AssignmentGroups (#3349) * [Horizon] Caching of the notebook (#3341) * [Horizon] Merge master (#3353) * [Horizon] Updated Flash Cards Design (#3350) * [Horizon] Padding update on CourseDetailsView (#3357) * [Horizon] Updating Attempts Allowed String for Singular Case (#3351) * [Horizon] Fix progress bar for course details & Scores (#3352) * [Horizon] Improve course fetching (#3366) * [Horizon] Bringing back the inbox and skillspace (#3359) * [Horizon] Merge master (#3369) * [Horizon] Add unread comment in assignment details & comment list (#3368) * [Horizon] Add drop list courses at course details (#3370) * [Horizon] Updating button styles (#3373) * Updating button styles [ignore-commit-lint] * Removing an unnecessary preview of a button * Removing a couple of commas that are preventing the build from succeeding * Removing a trailing comma that the linter doesn't like (#3381) * [Horizon] Removing Trailing Commas (#3382) * Removing a trailing comma that the linter doesn't like * Removing some more trailing commas * [Horizon] Display requirement for module item (#3380) * [Horizon] Fixing a bug where notes weren't saving under certain conditions (#3383) * [Horizon] Fix QR login (#3386) * [Horizon] Module Item Sequence Fix (#3387) * [Horizon] Hide courses drop down menu (#3389) * [Horizon] Authentication for Intelvio (#3400) * [Horizon] Remove Chips From Answer Prompt in Assist (#3392) * [Horizon] Fixed some UI bugs (#3394) * feat: add InstitutionLogo (#3397) * [Horizon] Add User ID to Notebook Notes in Cache (#3395) * [Horizon] Fix dashboard & course details ui issues (#3403) * Removing some type alias statements in the GetCoursesProgressionRequest to prevent hitting a limit on our graphql server (#3407) * [Horizon] Fix DropDownList course (#3405) * [Horizon] Add auth token for files (#3411) * feat: Display all requirement for module item (#3406) * [Horizon] Fix skillSpace router & Assist - Loading spinner (#3414) * [Horizon] Add the attached file for comments on assignments. (#3412) * [Horizon] Updating the scores number formatter to not include decimals (#3415) * [Horizon] Add base URL for institution logo when not set (#3418) * [Horizon] Merge master (#3425) * [Horizon] Add loader for noteBook (#3423) * feat: add back button & fix navigation on AI chats (#3427) * [Horizon] Fix Eliminate double network calls on learn tab (#3419) * [Horizon] Sanitizing the account name entered in to handle if the user types in http:// or https:// (#3430) * [Horizon] Assist styling & Ai Quiz updates (#3436) * Refresh the overview when performing a pull-to-refresh. (#3439) * [Horizon] Add a regenerate for flashcards (#3438) * [Horizon] Enable zoom on pages (#3440) * [Horizon] Add profile disable name fields (#3448) * [Horizon] Add Notifications Routing (#3451) * [Horizon] Add View Attempts for Assignments (#3452) * [Horizon] Fix AI UI Bugs (#3445) * [Horizon] Revert PKCE changes (#3458) * [Horizon] Merge master (#3459) * [Horizon] Add regenerate functionality for quiz and flashcards pagination (#3454) * feat: remove ui code from viewModel (#3469) * [Horizon] Master update (#3477) * [Horizon] Refactor assignment details (#3466) * Fix lean tap Ui (#3490) [ignore-commit-lint] * Fix: notification button color (#3487) * [Horizon] Add searchable feature for SingleSelect component (#3483) * [Horizon] Add Submission Comment pagination (#3475) * [Horizon] Native Inbox (#3480) * Adding the native implementation for the inbox view for horizon * Just a couple more tweaks of UI to the native inbox * Adding MultiSelect * WIP - Adding unit tests. Working on fetching the data from the contact book * More updates to the multiselect. Hooking up the recipients search. [ignore-git-commit] * WIP * WIP [ignore-commit-lint] * Making it so the inbox messages filter and search by person drop down can't be open at the same time. Fixing those to field popovers displaying underneath the list of results * Adding the Create Message page. Splitting out the PeopleSearch component * Adding in pagination to the inbox * Adding the TextArea UI element and finishing the UI part of the Create Message view * Updating Multiselect to use an ID with each option instead of the label as the identifier. Finishing off the Create Message * Adding a pull to refresh and auto refreshing the sent messages list from the create message page * WIP - Adding the HorizonMessageDetailsView * Ability to reply to messages and scrolls to the bottom when new messages come in * Polishing up padding * Adding file selection * Adding file attachments to the Create Message page * Adding file attachments to the message details * WIP - supporting attachments better and announcements * Fixing bugs. The only thing left is attachments don't work * Making it so I can reply to a message. Not sure why i still can't add attachments * Attachments now work * Removing logging statements * Adding downloading files * Adding the SwiftUIFlow dependency * Fixing the SwiftUI-Flow dependency * Small polish items * Polish polish polish * More polish [ignore-commit-lint] * Reverting unnecessary changes * Reverting unnecessary changes * some more updates after reviewing the code * Adding swiftui-flow to the ci version of hte project-ci.yml * Fixing a small bug in the inbox where selecting 'sent' + filtering by a person was not showing any results right away * Adding a spinner when downloading an attachment * Fixing a caching bug where an unread item could get marked as read, but still appear under the 'unread' filter * Removing the custom AttachmentItemView in favor of using the HorizonUI.Uploaded file. * Making it so you must select a course when creating a conversation. Also making it so when one drop down opens, the others are closed * Tightening up spacing on the inbox * Removing the SwiftUI-Flow dependency * Polish * Adding a call to url.startAccessingSecurityScopedResource before uploading a file * Addressing comments. [ignore-commit-lint] * Making it so we don't animate the view until the first message has come * Making it so the details page doesn't initially animate to the bottom of the scrollview * WIP * Adding back in the z index and fixing a background color issue on the single select * Fix for Single Select height being too large * Fix for Single Select height being too large * Making it so the keyboard dismisses on the message details page when the user taps on the message details. Also making it so we make one fewer api calls if a conversation is already read. * Confirming the upload of attachments * Simplifying the acknowledgement of a file upload * Simplifying the acknowledgement of a file upload * Fixing an issue where the multiselect component doesn't redraw itself unless the text field is given focus * Including the when responding to a message * Addressing merge comments * Wrapping HCreateMessageView Preview in DEBUG so it doesn't try to compile for release * Removing an import statement for SwiftUICore, opting for SwiftUI instead so that the automated deployment to the app store works * Fixing file attachments for replying * Swapping out some hardcoded values and removing a SwiftUI reference in a view model * fix: header * fix: test compile errors * Integration test fix * Fixing tests --------- Co-authored-by: szabinst <[email protected]> * Remove audience param (#3499) * [Horizon] Assist Introduction Updates CLX-1730 (#3496) * Adding the thumbs-up/thumbs down for assist chat. [ignore-commit-lint] * WIP [ignore-commit-lint] * WIP * WIP * Adding Cedar API calls and making the CoursePageGoal more capable * Adding some more options when viewing a page. * Disabling line length violations * Disabling line length violations * Making it so we can reset the environment * Making it so the course document goal actually does something * Making the translate option a little more generic * Removing the translation abilities for the moment * Removing the translation abilities for the moment * Code cleanup * Just updating a prompt * Addressing merge comments and improving the look of the assist chat * Fixing lint * Making it so you can press the back button while an assist message is in process and it cancels the request. * Making it so if we have lots of course options, it only presents the first 5. Making more options available to documents * Moving the related CourseDocument and CoursePage goals into a group * Satisfying swiftlint * Adding comments and section deliniation * Fixing Localizable.xcstrings * More code cleanup * Fixing a build error * Code Review * Code Review * Code Review * fix: resolve memory leaks * Fixing an empty response and back button not appearing in assist * Fixing Goals * Adding back error handling * Adding back error handling * Swiftlint fix --------- Co-authored-by: szabinst <[email protected]> * [Horizon] Merge master (#3500) * [Horizon] Add next modules icons in Dashboard (#3503) * [Horizon] Add loader at NQ (#3506) * [Horizon] Fix some UI bugs (#3509) * [Horizon] Unable to Select Multiple Recipients (#3511) * [Horizon] Send Button Not Enabled After Selecting Recipient (#3512) * [Horizon] Inbox Polish (#3513) * [Horizon] Fix some Ui issues (#3518) * [Horizon] Fix UI issues #3 (#3520) * [Horizon] WrappingHStack Improvement (#3514) * Fixing the layout of the WrappingHStack. It was shifting the position of the current line item down by the height of the current line, not by the height of the prior line height * Update WrappingHStack.swift [ignore-commit-lint] * [Horizon] Notebook Highlight Menu Adjustment (#3522) * Adjusting how the menu options are displayed for web highlights * Update HighlightWebView.swift [ignore-commit-lint] * [Horizon] Notebook Highlight Invalid Asset ID (#3502) * [Horizon] Cancel Download Fix (#3505) * [Horizon] Citations for Assist Responses (#3521) * fix notification header (#3526) * [Horizon] Fix inbox issues (#3527) * WIP - Moving some of our cedar requests to use Pine instead. [ignore-commit-lint] * [Horizon] Merge master (#3528) * Renaming a method call [ignore-commit-lint] * WIP [ignore-commit-lint] * changing the rag query we use as per direction of the domain services team * [Horizon] Rebranding Assist to Ignite (#3523) * Adding the zip file type as an option for attachments. Fixing the cancel download button not working. * Making it so if there's only one course, it's automatically selected * Making it so we can populate the with some suggested answers to help the user along * Fixing a typo * WIP [ignore-commit-lint] * Adding citations * WIP [ignore-commit-lint] * Working well * Addressing my own code review concerns * Fixing a small issue with opening the citation reference document * Adding the ability to summarize content * If the user isn't enrolled in any courses, tell them to enroll before using Assist * WIP * Retheming to Ignite [ignore-commit-lint] * Updating Assist suggestions [ignore-commit-lint] * Sentence case [ignore-commit-lint] * reordering suggested prompts [ignore-commit-lint] * updating the min height on the assist message view [ignore-commit-lint] * Addressing merge request comments [ignore-commit-lint] * Adding a placeholder for the Assist chat [ignore-commit-lint] * [Horizon] Fix Inbox Bugs (#3530) * Simplifying code [ignore-commit-lint] * removing the choose method from the goal interface * [Horizon] Fix Notebook bugs (#3534) * Fixing an issue where the spinner never goes away if the user doesn't have any messages yet [ignore-commit-lint] (#3535) * [Horizon] Adding Highlight Icons (#3540) * WIP [ignore-commit-lint] * Hooking up the iOS side to the web side to deliver the icon SVG data for highlighting [ignore-commit-lint] * Finishing the feature [ignore-commit-lint] * Small bug fix [ignore-commit-lint] * Fixing a loading issue [ignore-commit-lint] * small change after reviewing code [ignore-commit-lint] * fix header --------- Co-authored-by: Ahmed Naguib <[email protected]> * WIP [ignore-commit-lint] * Adding the ability to select a block of text and query ignite for more information [ignore-commit-lint] * Making it so selecting Explain This is a menu option that opens Assist [ignore-commit-lint] * Adding back in the duplicate assist data environment method [ignore-commit-lint] * WIP [ignore-commit-lint] * WIP [ignore-commit-lint] * Backing up and adding back the IgniteAI symbol to the menu and then letting the user choose to explain the text or ask another question about it [ignore-commit-lint] * Satisfying lint [ignore-commit-lint] * WIP * WIP [ignore-commit-lint] * [Horizon] Text Selection in Assist (#3546) * WIP [ignore-commit-lint] * Adding the ability to select a block of text and query ignite for more information [ignore-commit-lint] * Making it so selecting Explain This is a menu option that opens Assist [ignore-commit-lint] * Backing up and adding back the IgniteAI symbol to the menu and then letting the user choose to explain the text or ask another question about it [ignore-commit-lint] * Satisfying lint [ignore-commit-lint] * [Horizon] Making Assist Aware of Learn Tab Course ID (#3547) * Querying for the currently displayed courseID within the learn tab so that Assist becomes aware of which course is currently being displayed [ignore-commit-lint] * Fixing a retain cycle [ignore-commit-lint] * Making it so the initial chip suggestions from AssistCourseActionGoal don't have to reload if the user restarts the conversation [ignore-commit-lint] * WIP [ignore-commit-lint] * WIP [ignore-commit-lint] * [Horizon] Fix skill space header (#3551) * Integrating with the new Pine with document filtering * Merging in from feature/horizon [ignore-commit-lint] * 2.0 [ignore-commit-lint] * Merging in from master [ignore-commit-lint] * Removing files that shouldn't be there [ignore-commit-lint] * Removing more files that shouldn't be there [ignore-commit-lint] * Removing more files that shouldn't be there [ignore-commit-lint] * Reverting files that shouldn't be changed [ignore-commit-lint] * Fixing citation links [ignore-commit-lint] * Address merge request comments [ignore-commit-lint] * Refinement of the assist summarize tool [ignore-commit-lint] --------- Co-authored-by: szabinst <[email protected]> Co-authored-by: Ahmed Naguib <[email protected]> Co-authored-by: szabinst <[email protected]> Co-authored-by: Nate Armstrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is new?
1- https://instructure.atlassian.net/browse/CLX-1047
2- https://instructure.atlassian.net/browse/CLX-1083
3- https://instructure.atlassian.net/browse/CLX-1093
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-09.at.14.11.06.mp4