Skip to content

Conversation

ndrsszsz
Copy link
Contributor

@ndrsszsz ndrsszsz commented Mar 11, 2025

Accessibility - Parent - ManageStudents - textDark for placeholder color

refs: MBL-18391
affects: Parent
release note: None
test plan: See ticket.

Checklist

  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

refs: MBL-18391
affects: Parent
release note: None
test plan: See ticket.
@inst-danger
Copy link
Contributor

inst-danger commented Mar 11, 2025

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Mar 11, 2025

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Mar 11, 2025

Fails
🚫 Build failed, skipping coverage check
Warnings
⚠️ This pull request will not generate a release note.

Affected Apps: Parent

MBL-18391

❌ XCTest failed: StudentUnitTests/AssignmentRemindersInteractorLiveTests/testListsRemindersInChronologicalOrder
failed - Reminders are not in chronological order: [Student.AssignmentReminderItem(id: "3", title: "2 minutes before"), Student.AssignmentReminderItem(id: "1", title: "3 minutes before"), Student.AssignmentReminderItem(id: "2", title: "1 minute before")]

Generated by 🚫 dangerJS against 201ec54

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Tested on iPhone XS, iOS 18.3.0

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@rh12 rh12 merged commit debd241 into master Mar 13, 2025
3 of 5 checks passed
@rh12 rh12 deleted the bugfix/MBL-18391-a11y-parent-managestudents-textdark-placeholder-color branch March 13, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants