Update UIKit based disclosure indicators #3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18325 affects: Student, Teacher, Parent release note: none test plan: - UIKit based disclosure indicators should use textDark tint color.
vargaat
requested review from
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
Parent Build QR Code: |
Teacher Build QR Code: |
Student Build QR Code: |
suhaibabsi-inst
previously approved these changes
Mar 11, 2025
rh12
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Thanks for following this up!
There are a few missing (hidden in storyboards), you can search for the text "arrowOpenRightSolid":
PageListFrontPageCell uses the solid image directly, it's defined in the PageListViewController.storyboard
Similary, ErrorReportViewController.storyboard, MasteryPathAssignmentCell.xib (also has wrong color)
Maybe we should change from solid to line in AssignmentDetailsViewController's "Submission & Rubric" button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up for a previous PR that unified SwiftUI disclosure indicators but now it's for UIKit.
refs: MBL-18325
affects: Student, Teacher, Parent
release note: none
test plan:
Checklist