Skip to content

Conversation

petkybenedek
Copy link
Contributor

[ignore-commit-lint]

@petkybenedek petkybenedek self-assigned this Mar 6, 2025
@inst-danger
Copy link
Contributor

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.52% 91.53% -0.01%
Core/Core/Features/Grades/Model/Entities/GradeListData.swift 0% 0% 0%
Core/Core/Common/CommonUI/UIViews/HorizontalScrollingStackview.swift 0% 0% 0%

Generated by 🚫 dangerJS against 2176c86

@petkybenedek
Copy link
Contributor Author

petkybenedek commented Mar 6, 2025

Fix SwiftLint

The change in this branch makes it possible for SwiftLint to generate warnings again. This is achieved by modifying a build setting parameter with XcodeGen.

Known issue

Because of this fix, a new warning appears in Xcode:
image

This needs to be fixed in XcodeGen, but there is a way to fix it manually. Drag the Headers build phase before the SwiftLint build phase under Core target's build settings. This fix remains in effect until a new make sync command is executed.

An issue has been opened in XcodeGen's repository about the warning:
yonaskolb/XcodeGen#1507

@petkybenedek petkybenedek marked this pull request as ready for review March 6, 2025 13:15
Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will deal with this new warning in the PR that removes ObjC bridging headers.

@vargaat vargaat merged commit 540106c into master Mar 11, 2025
3 checks passed
@vargaat vargaat deleted the chore/fix-SwiftLint branch March 11, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants