Accessibility - Student - AssignmentDetails - Attempts date button traits handling #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aits handling refs: MBL-18457 affects: Student release note: None test plan: VoiceOver should read attempts date as a button only if it is really a button.
ndrsszsz
requested review from
vargaat,
szabinst,
rh12 and
suhaibabsi-inst
as code owners
Student Build QR Code: |
ndrsszsz
deleted the
bugfix/MBL-18457-a11y-student-assignment-details-attempts-date-button-traits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility - Student - AssignmentDetails - Attempts date button traits handling
refs: MBL-18457
affects: Student
release note: None
test plan: VoiceOver should read attempts date as a button only if it is really a button.
Previously that attemptsDateButton was read by VoiceOver as a "button" even if it was not active/clickable and that could be misleading to the user. Now if the button is not active then we set the accessibilityTraits of the button to staticText.
Checklist