Skip to content

Conversation

ndrsszsz
Copy link
Contributor

@ndrsszsz ndrsszsz commented Feb 6, 2025

Parent - Grade List - Section header button trait

refs: MBL-18395
affects: Student, Parent
release note: None
test plan: VoiceOver should read section headers as button.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

refs: MBL-18395
affects: Student, Parent
release note: None
test plan: VoiceOver should read section headers as button.
@inst-danger
Copy link
Contributor

Parent Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Feb 6, 2025

Warnings
⚠️ This pull request will not generate a release note.
⚠️ One or more files are below the minimum test coverage 50%

Affected Apps: Student, Parent

MBL-18395

Coverage New % Master % Delta
Canvas iOS 91.35% 91.35% 0%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift 48.72% 48.72% 0%
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift 0% 0% 0%
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%

Generated by 🚫 dangerJS against a5b66b3

Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

@vargaat vargaat merged commit 2b899d7 into master Feb 7, 2025
5 checks passed
@vargaat vargaat deleted the bugfix/MBL-18395-a11y-parent-grades-section-header-button-traits branch February 7, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants