Parent - TeacherChat - Compose screen - add accessibilityHint to input fields #3111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t fields refs: MBL-18368 affects: Parent release note: None test plan: VoiceOver should read both "subject" and "body" input fields as "text field".
ndrsszsz
requested review from
vargaat,
szabinst,
rh12 and
suhaibabsi-inst
as code owners
Teacher Build QR Code: |
Parent Build QR Code: |
Affected Apps: Parent
|
suhaibabsi-inst
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
QA +1
One note though, I noticed that when Voice Over is read over subject and message it mentions "Input" word within it. Which I am not sure is intentional.
For example, subject is read out as this:
Subject input, text field, enter a subject for your message, double tap to edit.
The same is read out for Message field as well.
vargaat
approved these changes
Feb 10, 2025
vargaat
deleted the
bugfix/MBL-18368-a11y-parent-chat-compose-message-input-field-traits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent - TeacherChat - Compose screen - add accessibilityHint to input fields
Ideally all input fields should have an accessibility trait as "text field" or "text input" or something like that, and most cases VoiceOver recognises these elements correctly, but for UITextView and UITextField it just doesn't work like that.
Since there is no accessibility trait that we could add to these for this case (textField or textInput) I added it as an accessibilityHint. VoiceOver reads it like it was a trait but it's a hint instead. I made some research and investigated what could be done and found no better solution than this one, but I'm open to any ideas. My guess is that UIKit text inputs have some issues with being accessible (the internet says other devs experienced similar accessibility issues with these components).
refs: MBL-18368
affects: Parent
release note: None
test plan: VoiceOver should read both "subject" and "body" input fields as "text field".
Checklist