Skip to content

Fixes issue where Files are not showing for user of Consortia root account #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fixes issue where Files are not showing for user of Consortia root account #3106

merged 3 commits into from
Feb 4, 2025

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Feb 3, 2025 •
edited by rh12
Loading

refs: MBL-18552
affects: Student, Teacher
release note: Fixed the issue where Course Files not shown properly in some cases.

Test Plan

See ticket's description.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@suhaibabsi-inst suhaibabsi-inst self-assigned this Feb 3, 2025
@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review February 3, 2025 14:21
@inst-danger
Copy link
Contributor

inst-danger commented Feb 3, 2025 •
edited
Loading

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Feb 3, 2025 •
edited
Loading

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Feb 3, 2025 •
edited by jira bot
Loading

Fails
🚫 Build failed, skipping coverage check
Warnings
⚠️ This pull request will not generate a release note.

Affected Apps: Student, Teacher

MBL-18552

❌ XCTest failed: CoreTests/WKHTTPCookieStoreExtensionsTests/testDeleteAllCookies 
Asynchronous wait failed: Exceeded timeout of 0.1 seconds, with unfulfilled expectations: "Publisher finished".
XCTAssertEqual failed: ("[<NSHTTPCookie
	version:1
	name:testName
	value:testValue
	expiresDate:'(null)'
	created:'2025-02-03 19:49:14 +0000'
	sessionOnly:TRUE
	domain:instructure.com
	partition:none
	sameSite:none
	path:/login
	isSecure:FALSE
 path:"/login" isSecure:FALSE>]") is not equal to ("[]")

Generated by 🚫 dangerJS against e9e239d

vargaat
vargaat previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

ndrsszsz
ndrsszsz previously approved these changes Feb 3, 2025
View reviewed changes
@suhaibabsi-inst suhaibabsi-inst dismissed stale reviews from ndrsszsz and vargaat via e9e239d February 3, 2025 19:43
ndrsszsz
ndrsszsz approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@suhaibabsi-inst suhaibabsi-inst merged commit 3cda980 into master Feb 4, 2025
3 of 5 checks passed
@suhaibabsi-inst suhaibabsi-inst deleted the bugfix/MBL-18552-Consortia-Files-Page branch February 4, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vargaat vargaat vargaat approved these changes

@ndrsszsz ndrsszsz ndrsszsz approved these changes

@szabinst szabinst Awaiting requested review from szabinst szabinst is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

Assignees

@suhaibabsi-inst suhaibabsi-inst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suhaibabsi-inst @inst-danger @vargaat @ndrsszsz