Skip to content

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Jan 31, 2025

refs: MBL-18561
affects: Student, Teacher
release note: none

(no release note, because the issue this one fixes was not released yet)

test plan:

  • Create a global announcement.
  • Start apps.
  • Tap on the announcement on dashboard to view its contents.
  • Content should appear.

Checklist

  • Tested on phone
  • Tested on tablet

refs: MBL-18561
affects: Student, Teacher
release note: none

test plan:
- Create a global announcement.
- Start apps.
- Tap on the announcement on dashboard to view its contents.
- Content should appear.
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 31, 2025

Fails
🚫 Build failed, skipping coverage check
Warnings
⚠️ This pull request will not generate a release note.

Affected Apps: Student, Teacher

MBL-18561

❌ XCTest failed: CoreTests/WKHTTPCookieStoreExtensionsTests/testDeleteAllCookies
Asynchronous wait failed: Exceeded timeout of 0.1 seconds, with unfulfilled expectations: "Publisher finished".

Generated by 🚫 dangerJS against dd0b169

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1
Tested on iPhone XS, iOS 18.2.1, Teacher & Student apps.

@rh12 rh12 merged commit 0d88e83 into master Feb 3, 2025
3 of 5 checks passed
@rh12 rh12 deleted the bugfix/MBL-18561-Fix-swiftui-webview-content-not-loading branch February 3, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants