Skip to content

Accessibility - Teacher - Profile - Avatar as button #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Accessibility - Teacher - Profile - Avatar as button #3067

merged 1 commit into from
Jan 21, 2025

Conversation

ndrsszsz
Copy link
Contributor

@ndrsszsz ndrsszsz commented Jan 14, 2025 •
edited by balintbartok
Loading

affects: Student, Teacher, Parent
release note: None
test plan: VoiceOver should read Avatar image as button.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@ndrsszsz
refs: MBL-18335
07fa69b 
affects: All
release note: None
test plan: VoiceOver should read Avatar image as button.
@ndrsszsz ndrsszsz self-assigned this Jan 14, 2025
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Parent Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 14, 2025 •
edited by jira bot
Loading

Fails
🚫 You have included an invalid app. Valid values are: Student, Teacher, Parent, None
Warnings
⚠️ This pull request will not generate a release note.
⚠️ One or more files are below the minimum test coverage 50%

MBL-18335

Coverage New % Master % Delta
Canvas iOS 91.28% 91.29% -0.01%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift 48.72% 48.72% 0%
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift 0% 0% 0%
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%

Generated by 🚫 dangerJS against 07fa69b

suhaibabsi-inst
suhaibabsi-inst reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

suhaibabsi-inst
suhaibabsi-inst approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@balintbartok balintbartok merged commit e231b7e into master Jan 21, 2025
5 of 6 checks passed
@balintbartok balintbartok deleted the bugfix/MBL-18335-a11y-teacher-profile-avatar-button branch January 21, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhaibabsi-inst suhaibabsi-inst suhaibabsi-inst approved these changes

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

@szabinst szabinst Awaiting requested review from szabinst szabinst is a code owner

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

Assignees

@ndrsszsz ndrsszsz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndrsszsz @inst-danger @suhaibabsi-inst @balintbartok