Move SubmissionController to core module #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ignore-commit-lint]
Ahmed-Naguib93
requested review from
vargaat,
szabinst,
rh12,
ndrsszsz and
suhaibabsi-inst
as code owners
Ahmed-Naguib93
changed the title
Student Build QR Code: |
❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor |
rh12
requested changes
Dec 17, 2024
Student/StudentUnitTests/Submissions/TextSubmission/TextSubmissionViewControllerTests.swift
Outdated
Show resolved
Hide resolved
suhaibabsi-inst
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
QA +1
Regression test passed for Consortia account issue, see this PR.
szabinst
deleted the
feature/move-TextSubmissionViewController-to-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move SubmissionController to parent module