Skip to content

Conversation

ndrsszsz
Copy link
Contributor

refs: MBL-18168
affects: Student, Teacher
release note: Improved assignment list and assignment list preferences screen.
test plan: See ticket.

Should fix the following issues (test plan)

  • When opening the assignment list screen for the first time, the current grading period fails to get selected automatically and shows "All" instead of the current one, and only shows the correct one after PTR.
  • Assignment List Preferences screen doesn't have backgroundLightest as background colour.

Screenshots

Assignment List Preferences (background colour difference)

BeforeAfter

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@inst-danger
Copy link
Contributor

inst-danger commented Dec 11, 2024

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 11, 2024

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 11, 2024

Fails
🚫 Build failed, skipping coverage check

Release Note:

Improved assignment list and assignment list preferences screen.

Affected Apps: Student, Teacher

MBL-18168

❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor
XCTAssertEqual failed: ("#6a7883") is not equal to ("#697783")
XCTAssertEqual failed: ("#03893d") is not equal to ("#03893c")

Generated by 🚫 dangerJS against c36d339

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1, I couldn't reproduce the issue with a few tries. The solution is quite hacky (as we discussed) but works so let's keep it as-is and improve the AssignmentListViewModel as a whole at a later time.

@ndrsszsz ndrsszsz merged commit 317f92f into master Dec 16, 2024
3 of 5 checks passed
@ndrsszsz ndrsszsz deleted the feature/MBL-18168-assignment-list-preferences-improvements branch December 16, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants