Fix Appearance (Light/Dark Mode) Issues of Course Smart Search #3016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18169 affects: Student release note: Fixed appearance (light/dark mode) issues for Course Smart Search
suhaibabsi-inst
changed the title
Student Build QR Code: |
Release Note:Fixed appearance (light/dark mode) issues for Course Smart Search Affected Apps: Student❌ XCTest failed: CoreTests/AssignmentCellViewModelTests/testSubmissionStatusAndIconAndColor |
suhaibabsi-inst
requested review from
vargaat,
szabinst,
rh12 and
ndrsszsz
as code owners
vargaat
requested changes
Dec 16, 2024
Core/Core/Contexts/Context.swift
Outdated
Comment on lines
102
to
106
| var color: UIColor? { contextColor?.color } | ||
|
|
||
| var contextColor: ContextColor? { | ||
| contextColor(in: AppEnvironment.shared.database.viewContext) | ||
| } |
There was a problem hiding this comment.
I would remove these helpers to make it explicit that these properties are not part of the Context object and fast to access because in the background they do a CoreData fetch that could have negative effect on performance if used frequently for example during SwiftUI rendering. The functions below are clearer for me that they work with CoreData to produce the result and might be slow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18169
affects: Student
release note: Fixed appearance (light/dark mode) issues for Course Smart Search
Test Plan
See ticket description.
Checklist