Skip to content

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Dec 8, 2024

refs: MBL-18147
affects: Student
release note: Fixed groups from unpublished courses showing up on All Courses list.

Test Plan

See ticket description.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

refs: MBL-18147
affects: Student
release note: Fixed groups from unpublished courses showing up on All Courses list.

test plan: See ticket.
@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Dec 8, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Fixed groups from unpublished courses showing up on All Courses list.

Affected Apps: Student

MBL-18147

Coverage New % Master % Delta
Canvas iOS 91.16% 91.17% -0.01%
Core/Core/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%
Core/Core/Extensions/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Courses/SmartSearch/View/CourseSmartSearchViewsProvider.swift 13.64% 13.64% 0%
Core/Core/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Store/FetchedCollection.swift 48.72% 48.72% 0%

Generated by 🚫 dangerJS against 2ee22a5

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@vargaat vargaat merged commit 9d45d1c into master Dec 16, 2024
4 checks passed
@vargaat vargaat deleted the bugfix/MBL-18147-Groups-Of-Unpublished branch December 16, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants