Skip to content

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Oct 30, 2024

refs: MBL-17988
affects: Student,Teacher
release note: Fix the issue of annotation bar move button being cut off on landscape mode.

Test Plan

See ticket description for more information about use case testing:
https://instructure.atlassian.net/browse/MBL-17988

Screenshots

BeforeAfter
More Fixed (iPhone)
More Fixed (iPad)

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

…e mode

refs: MBL-17988
affects: Student,Teacher
release note: Fix the issue of annotation bar move button being cut off on landscape mode.

test plan: See PR description
@suhaibabsi-inst suhaibabsi-inst self-assigned this Oct 30, 2024
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 30, 2024

Release Note:

Fix the issue of annotation bar move button being cut off on landscape mode.

Affected Apps: Student, Teacher

MBL-17988

Coverage New % Master % Delta
Canvas iOS 91.7% 91.7% 0.01%

Generated by 🚫 dangerJS against e3fba1a

@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review October 30, 2024 10:29
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1
Tested on iPhone 11, iOS 18.1

@suhaibabsi-inst suhaibabsi-inst merged commit 4548dd4 into master Oct 30, 2024
5 of 6 checks passed
@suhaibabsi-inst suhaibabsi-inst deleted the bugfix/MBL-17988 branch October 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants