Skip to content

Implement Assignments Offline E2E test case #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 5, 2024
Merged

Implement Assignments Offline E2E test case #2956

merged 11 commits into from
Nov 5, 2024

Conversation

kdeakinstructure
Copy link
Contributor

refs: MBL-18034
affects: Student
release note: none

Implement Offline Assignments E2E test case.
Add new helper (OfflineHelper) for Offline mode dialog (and future usage).

@kdeakinstructure
refs: MBL-18034
7592f35 
affects: Student
release note: none

Implement Offline Assignments E2E test case.
Add new helper (OfflineHelper) for Offline mode dialog (and future usage).
@kdeakinstructure
Minor refactor.
8e1e98f
@inst-danger
Copy link
Contributor

inst-danger commented Oct 28, 2024 •
edited
Loading

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 28, 2024 •
edited by jira bot
Loading

Warnings
⚠️ This pull request will not generate a release note.

Affected Apps: Student

MBL-18034

Coverage New % Master % Delta
Canvas iOS 91.7% 91.7% 0%

Generated by 🚫 dangerJS against 9d7ffa7

ndrsszsz
ndrsszsz requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some changes and please pay attention for the linter issues (whitespace violation).
However, congrats for your first iOS PR! 🥳

szabinst
szabinst reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@szabinst szabinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it needed to add those files to gitignore? I'm against ignoring Package.resolved as it provides a way for us to see updates. The brewfile lock is probably fine because it's not like Gemfile.lock and others.

@kdeakinstructure
Copy link
Contributor Author

Why was it needed to add those files to gitignore? I'm against ignoring Package.resolved as it provides a way for us to see updates. The brewfile lock is probably fine because it's not like Gemfile.lock and others.

Discussed via Slack, thanks.

vargaat
vargaat previously approved these changes Nov 4, 2024
View reviewed changes
ndrsszsz
ndrsszsz previously approved these changes Nov 4, 2024
View reviewed changes
@kdeakinstructure kdeakinstructure dismissed stale reviews from ndrsszsz and vargaat via c94a330 November 4, 2024 19:11
@szabinst szabinst self-requested a review November 5, 2024 08:40
@kdeakinstructure kdeakinstructure merged commit 8cae588 into master Nov 5, 2024
4 of 5 checks passed
@kdeakinstructure kdeakinstructure deleted the MBL-18034-implement-offline-assignments-e2e-test branch November 5, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabinst szabinst szabinst approved these changes

@ndrsszsz ndrsszsz ndrsszsz approved these changes

@rh12 rh12 Awaiting requested review from rh12 rh12 is a code owner

@suhaibabsi-inst suhaibabsi-inst Awaiting requested review from suhaibabsi-inst suhaibabsi-inst is a code owner

@vargaat vargaat Awaiting requested review from vargaat vargaat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kdeakinstructure @inst-danger @vargaat @szabinst @ndrsszsz