-
Notifications
You must be signed in to change notification settings - Fork 122
Calendar event custom frequency prefill #2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rh12
merged 10 commits into
master
from
feature/MBL-17971-Calendar-Event-Custom-Frequency-prefill
Oct 28, 2024
Merged
Calendar event custom frequency prefill #2946
rh12
merged 10 commits into
master
from
feature/MBL-17971-Calendar-Event-Custom-Frequency-prefill
Oct 28, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhaibabsi-inst
previously approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
refs: MBL-17971 affects: Student, Teacher release note: Custom calendar frequency screen now reuses the currently selected frequency. test plan: See PR description
…ventFrequencyViewModel
8fb162c
to
5e2caa9
Compare
vargaat
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA+1
suhaibabsi-inst
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-17971
affects: Student, Teacher
release note: Custom calendar frequency screen now reuses the currently selected frequency.
What's changed
CustomFrequency screen is now prefilled with values from the current selection in the previous screen.
Tapping "Custom" when current selection is:
Chores
EditEventFrequencyScreen
toSelectEventFrequencyScreen
FrequencyChoice
toFrequencyPresetViewModel
Date
extensions to its dedicated file, etc.)DateExtensions.swift
Test plan
Checklist