Skip to content

Conversation

rh12
Copy link
Contributor

@rh12 rh12 commented Oct 22, 2024

refs: MBL-17971
affects: Student, Teacher
release note: Custom calendar frequency screen now reuses the currently selected frequency.

What's changed

CustomFrequency screen is now prefilled with values from the current selection in the previous screen.

Tapping "Custom" when current selection is:

  • "Does not repeat", it still shows the default state, where nothing is prefilled
  • a predefined option (daily/weekly/monthly/annually/weekdays), it prefills values accordingly
  • custom frequencies, it prefills values accordingly, both when:
    • coming from backend (and has it's own backend provided title)
    • set by the user but not Saved to backend yet ("Custom" option)

Chores

  • Improved Back button animation
  • Renamed EditEventFrequencyScreen to SelectEventFrequencyScreen
  • Renamed FrequencyChoice to FrequencyPresetViewModel
  • Rearranged helpers, methods (like moving general Date extensions to its dedicated file, etc.)
  • Removed some unused code
  • Cleaned up DateExtensions.swift
  • Added various comments & documentation
  • Silenced coverage warnings

Test plan

  • Verify prefill works as described above
  • Verify selecting, saving, updating frequencies work as before

Checklist

  • Follow-up e2e test ticket created
  • Tested on phone
  • Tested on tablet

@inst-danger
Copy link
Contributor

inst-danger commented Oct 22, 2024

Release Note:

Custom calendar frequency screen now reuses the currently selected frequency.

Affected Apps: Student, Teacher

MBL-17971

Coverage New % Master % Delta
Canvas iOS 91.7% 91.07% 0.64%

Generated by 🚫 dangerJS against 6dae0ab

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

rh12 added 6 commits October 24, 2024 13:48
refs: MBL-17971
affects: Student, Teacher
release note: Custom calendar frequency screen now reuses the currently selected frequency.

test plan: See PR description
@rh12 rh12 force-pushed the feature/MBL-17971-Calendar-Event-Custom-Frequency-prefill branch from 8fb162c to 5e2caa9 Compare October 24, 2024 11:49
@inst-danger
Copy link
Contributor

inst-danger commented Oct 24, 2024

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 24, 2024

Student Build QR Code:

@rh12 rh12 requested a review from suhaibabsi-inst October 24, 2024 15:45
Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rh12 rh12 merged commit 415c02d into master Oct 28, 2024
5 of 6 checks passed
@rh12 rh12 deleted the feature/MBL-17971-Calendar-Event-Custom-Frequency-prefill branch October 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants