Skip to content

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Oct 17, 2024

I noticed that there are significant lags and fps drops on screens using the ContextButton button style. This was because this style re-calculated the color to get it to the minimum contrast ratio but in fact colors reaching the UI should already have enough contrast ratio after the color palette update that we delivered recently.

affects: Student, Teacher, Parent

[ignore-commit-lint]

Screenshots

BeforeAfter
RPReplay_Final1729154828.MP4
RPReplay_Final1729155047.MP4

Checklist

  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode

@vargaat vargaat requested review from szabinst and rh12 as code owners October 17, 2024 09:05
@inst-danger
Copy link
Contributor

Parent Build QR Code:

@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.18% 91.18% -0.01%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against 7a40ad5

@Ahmed-Naguib93
Copy link
Contributor

QA +1

@vargaat vargaat self-assigned this Oct 17, 2024
@vargaat vargaat requested a review from ndrsszsz October 17, 2024 11:31
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@vargaat vargaat merged commit 96f0836 into master Oct 21, 2024
6 checks passed
@vargaat vargaat deleted the chore/fix-ui-lag branch October 21, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants