Remove unnecessary color contrast calculation #2939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are significant lags and fps drops on screens using the ContextButton button style. This was because this style re-calculated the color to get it to the minimum contrast ratio but in fact colors reaching the UI should already have enough contrast ratio after the color palette update that we delivered recently.
affects: Student, Teacher, Parent
[ignore-commit-lint]
Screenshots
RPReplay_Final1729154828.MP4
RPReplay_Final1729155047.MP4
Checklist