Skip to content

Conversation

szabinst
Copy link
Collaborator

@szabinst szabinst commented Oct 16, 2024

Moves Quiz related screens from Student to Core so it can be reused in Horizon.
Added a prefix to Teacher Quiz files.

[ignore-commit-lint]

Checklist

  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode

[ignore-commit-lint]
@szabinst szabinst self-assigned this Oct 16, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Oct 16, 2024

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 16, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.18% 91.18% -0%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against de7f2b8

@inst-danger
Copy link
Contributor

inst-danger commented Oct 16, 2024

Teacher Build QR Code:

@szabinst szabinst marked this pull request as ready for review October 16, 2024 14:20
@szabinst szabinst requested review from vargaat and rh12 as code owners October 16, 2024 14:20
rh12
rh12 previously approved these changes Oct 17, 2024
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1 (smoke tested quizes in both apps)

@szabinst szabinst merged commit 8a720cc into master Oct 18, 2024
5 of 6 checks passed
@szabinst szabinst deleted the chore/move-student-quiz-to-core branch October 18, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants