Skip to content

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Oct 10, 2024

  • Fixed file parsing failing when filename is null.
  • Fixed offline content selector screen not reacting to cancel when in error or loading states.

refs: MBL-17877
affects: Student
release note: Fixed cancel not working on offline sync picker screen while the screen is loading or displaying an error. Fixed offline sync picker failing to load in some cases.

test plan: See ticket.

Checklist

  • Tested on phone
  • Tested on tablet

…elector screen not reacting to cancel when in error or loading states.

refs: MBL-17877
affects: Student
release note: Fixed cancel not working on offline sync picker screen while the screen is loading or displaying an error. Fixed offline sync picker failing to load in some cases.

test plan: See ticket.
@vargaat vargaat self-assigned this Oct 10, 2024
@vargaat vargaat requested review from szabinst and rh12 as code owners October 10, 2024 16:06
@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 10, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Fixed cancel not working on offline sync picker screen while the screen is loading or displaying an error. Fixed offline sync picker failing to load in some cases.

Affected Apps: Student

MBL-17877

Coverage New % Master % Delta
Canvas iOS 91.13% 91.12% 0.01%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against 7789452

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@vargaat vargaat requested a review from ndrsszsz October 15, 2024 12:35
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@vargaat vargaat merged commit f61c4dd into master Oct 15, 2024
4 checks passed
@vargaat vargaat deleted the bugfix/MBL-17877-Fix-file-parsing branch October 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants