Skip to content

Fix Observer Alert list #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 21, 2024
Merged

Fix Observer Alert list #2925

merged 9 commits into from
Oct 21, 2024

Conversation

rh12
Copy link
Contributor

@rh12 rh12 commented Oct 9, 2024 •
edited by vargaat
Loading

refs: MBL-17893
affects: Parent
release note: Fixed alert list not refreshing after an alert is read or dismissed.

What's changed

  • Parent app alert list now updates dynamically after opening an alert or dismissing it
  • Tab bar badge now also updates dynamically
  • Dismiss is animated now

Chores

  • rearranged ObserverAlert related files and moved most of them to Parent app

Test plan

  • Verify the blue dot which marks an unread alert disappears after the alert was opened
  • Verify that dismissing an alert removes it from the list of alerts
  • Smoke test alert list and its refresh

HINT: An easy way to create alerts is to create announcements in Teacher app.

Checklist

  • Follow-up e2e test ticket created
  • Tested on phone
  • Tested on tablet

@rh12 rh12 self-assigned this Oct 9, 2024
@rh12 rh12 requested review from vargaat and szabinst as code owners October 9, 2024 21:18
@inst-danger
Copy link
Contributor

inst-danger commented Oct 9, 2024 •
edited
Loading

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 9, 2024 •
edited
Loading

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 9, 2024 •
edited by jira bot
Loading

Fails
🚫 Build failed, skipping coverage check

Release Note:

Fixed alert list not refreshing after an alert is read or dismissed.

Affected Apps: Parent

MBL-17893

❌ XCTest failed: StudentUnitTests/AssignmentRemindersInteractorLiveTests/testListsRemindersInChronologicalOrder 
failed - waitUntil timed out

Generated by 🚫 dangerJS against 8122fdc

vargaat
vargaat previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

@vargaat vargaat requested a review from ndrsszsz October 15, 2024 12:34
vargaat
vargaat previously approved these changes Oct 17, 2024
View reviewed changes
ndrsszsz
ndrsszsz approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@rh12 rh12 merged commit d32428b into master Oct 21, 2024
3 of 5 checks passed
@rh12 rh12 deleted the bugfix/MBL-17893-Observer-Alerts branch October 21, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vargaat vargaat vargaat approved these changes

@ndrsszsz ndrsszsz ndrsszsz approved these changes

@szabinst szabinst Awaiting requested review from szabinst szabinst is a code owner

@suhaibabsi-inst suhaibabsi-inst Awaiting requested review from suhaibabsi-inst suhaibabsi-inst is a code owner

@Ahmed-Naguib93 Ahmed-Naguib93 Awaiting requested review from Ahmed-Naguib93

Assignees

@rh12 rh12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rh12 @inst-danger @vargaat @ndrsszsz