Skip to content

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Oct 9, 2024

refs: MBL-17939
affects: Teacher
release note: Fixed LTI content embedded in RCE submissions not displaying in SpeedGrader.

test plan: See ticket

Screenshots

BeforeAfter

Checklist

  • Follow-up e2e test ticket created
  • Tested on phone
  • Tested on tablet

refs: MBL-17939
affects: Teacher
release note: Fixed LTI content embedded in RCE submissions not displaying in SpeedGrader.

test plan: See ticket
@vargaat vargaat requested review from szabinst and rh12 as code owners October 9, 2024 15:03
@vargaat vargaat self-assigned this Oct 9, 2024
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 9, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Fixed LTI content embedded in RCE submissions not displaying in SpeedGrader.

Affected Apps: Teacher

MBL-17939

Coverage New % Master % Delta
Canvas iOS 91.12% 91.12% 0%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against 6d11171

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

The only thing I noticed is that we display no loading indicator after opening the page, which is especially noticeable in Light Mode, because in Dark Mode at least the empty white page shows soon.
But I believe this is entirely unrelated to this PR.

@vargaat vargaat requested a review from ndrsszsz October 15, 2024 11:39
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@vargaat vargaat merged commit 00c1531 into master Oct 15, 2024
4 checks passed
@vargaat vargaat deleted the bugfix/MBL-17939-Fix-LTI-in-speedgrader branch October 15, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants