Skip to content

Conversation

vargaat
Copy link
Collaborator

@vargaat vargaat commented Oct 7, 2024

  • The Cocoapods based dSYM uploads were removed from Bitrise workflows.
  • I added dSYM uploads to Xcode projects using the SPM based Firebase installation. This is based on an environment variable that the app store bitrise workflows pass down to xcodebuild so only the app store builds are executing this step.
  • Created a dedicated folder for scripts used in Xcode build phases.
  • Updated Swiftlint configuration after Pods and React removal.

affects: Student, Teacher, Parent

@vargaat vargaat self-assigned this Oct 7, 2024
@vargaat vargaat requested review from szabinst and rh12 as code owners October 7, 2024 15:35
@inst-danger
Copy link
Contributor

inst-danger commented Oct 7, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.12% 91.12% 0.01%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against 4f5a43c

@vargaat vargaat closed this Oct 8, 2024
@vargaat vargaat reopened this Oct 8, 2024
@inst-danger
Copy link
Contributor

Parent Build QR Code:

@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@vargaat vargaat merged commit 4dee1cd into master Oct 15, 2024
6 checks passed
@vargaat vargaat deleted the chore/upload-dsyms branch October 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants