Skip to content

Conversation

Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93 Ahmed-Naguib93 commented Oct 7, 2024

refs: MBL-17951
affects: Student , Parent
release note: Added letter grade when toggling based on graded assignments on grade screen

Test plan:

  • Open student or parent app.
  • Navigate to grade.
  • Change toggle graded assignments state will see the grade letter change.

Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-07.at.15.28.05.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-07.at.15.30.19.mp4

Checklist

  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode

refs:MBL-17951
affects:Student , Parent
release note:

test plan:
refs:MBL-17951
affects: Student, Parent
release note: Added letter grade when toggling based on graded assignments on grade screen

test plan:
…d-when-toggling-based-on-graded-assignments-on-grade-screen
refs: MBL-17951
affects:Student, Parent
release note:Added letter grade when toggling based on graded assignments on grade screen

test plan:
refs:MBL-17951
affects:Student, Parent
release note: Added letter grade when toggling based on graded assignments on grade screen

test plan:
@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Oct 7, 2024
@Ahmed-Naguib93 Ahmed-Naguib93 changed the title Feature/mbl 17951 letter grade not updated when toggling based on graded assignments on grade screen Change letter grade when toggling based on graded assignments on grade screen Oct 7, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Oct 7, 2024

Parent Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 7, 2024

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 7, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Added letter grade when toggling based on graded assignments on grade screen

Affected Apps: Student, Parent

MBL-17951

Coverage New % Master % Delta
Canvas iOS 91.17% 91.12% 0.06%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against f4af9e5

refs:MBL-17951
affects:Student , Parent
release note:Added letter grade when toggling based on graded assignments on grade screen

test plan:
vargaat
vargaat previously approved these changes Oct 9, 2024
Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my code review findings below.

refs:MBL-17951
affects:Student , Parent
release note:Added letter grade when toggling based on graded assignments on grade screen

test plan:
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Thanks for the changes!

@vargaat vargaat merged commit 5645dab into master Oct 15, 2024
5 checks passed
@vargaat vargaat deleted the feature/MBL-17951--Letter-grade-not-updated-when-toggling-based-on-graded-assignments-on-grade-screen branch October 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants