Fix issues of Xcode 16 #2899

suhaibabsi-inst · 2024-09-24T09:13:51Z

This is to fix issues preventing builds compiling on Xcode 16

Checklist

inst-danger · 2024-09-24T09:18:42Z

	Warnings
⚠️	One or more files are below the minimum test coverage 50%

Coverage	New %	Master %	Delta
Canvas iOS	91.08%	91.17%	-0.09%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift	0%	0%	0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift	0%	0%	0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift	43.33%	43.33%	0%
Core/Core/Grades/View/CustomSwipeAction.swift	0%	0%	0%

Generated by 🚫 dangerJS against 82436b3

szabinst · 2024-09-25T08:10:22Z

When trying to build for iOS 18 simulator, I get a crash. Simulators with < iOS 18.0 works well.

suhaibabsi-inst · 2024-09-25T10:30:57Z

@szabinst

Updating PSDPDFKit to version 13.9.1 to resolves the issue, while we aim with it to keep supporting pre Xcode 16 for those who still need more time to update.
Once, all the team is on Xcode 16, I think we should pump this one to 14.0.0 for better support as per their change log.

szabinst · 2024-09-25T11:23:44Z

@suhaibabsi-inst Please remove affects, etc.. commit message and use [ignore-commit-lint] so danger succeeds.

rh12

Built & run successfully on Xcode15.4.
Test build failed, please see comment below.
We could either work around this somehow, or revert this change and accept that Xcode16 test builds will fail until the whole team updates to Xcode in the near future.

Core/Core/Localizable.xcstrings

Core/CoreTests/Discussions/DiscussionDetailsViewControllerTests.swift

[ignore-commit-lint]

suhaibabsi-inst · 2024-09-30T08:20:51Z

Will be waiting to merge this until the release is cut.

…ting targets.

# Conflicts: # Core/Core/ObserverAlerts/GetObserverAlerts.swift

…dge updates.

refs: MBL-17890 affects: Student, Teacher, Parent release note: none test plan:

… TestsFoundation projects.

- Update projects to recommended settings. - Add reverse relationship to Quiz

rh12

Code review +1

rh12 · 2024-10-24T07:24:30Z

Core/Core/Extensions/HTTPCookieExtensions.swift

@@ -40,5 +40,27 @@ public extension HTTPCookie {
        )!
    }

+    /// The default equality check returns false even when all properties match
+    /// so we created this custom comparison to test property equality between this and another cookie.
+    public func equalsProperties(to anotherCookie: HTTPCookie?) -> Bool {


Suggested change

public func equalsProperties(to anotherCookie: HTTPCookie?) -> Bool {

public func isEqualProperties(to anotherCookie: HTTPCookie?) -> Bool {

szabinst

LGTM on both simulator, physical device.

…moving the custom class name from the database model.

rh12

QA + 1
Built & run on iOS 17 (iPad, iPhone, iPhone simulator)
All 3 apps seem to work as before.

… name found.

suhaibabsi-inst marked this pull request as ready for review September 24, 2024 09:16

suhaibabsi-inst requested review from vargaat, szabinst and rh12 as code owners September 24, 2024 09:16

suhaibabsi-inst self-assigned this Sep 24, 2024

szabinst previously approved these changes Sep 25, 2024

View reviewed changes

rh12 requested changes Sep 25, 2024

View reviewed changes

Core/Core/Localizable.xcstrings Outdated Show resolved Hide resolved

Core/CoreTests/Discussions/DiscussionDetailsViewControllerTests.swift Show resolved Hide resolved

Fix issues of Xcode 16

a4a44d2

[ignore-commit-lint]

suhaibabsi-inst dismissed szabinst’s stale review via a4a44d2 September 25, 2024 14:20

suhaibabsi-inst force-pushed the bugfix/Xcode16-Fixes branch from aff1766 to a4a44d2 Compare September 25, 2024 14:20

suhaibabsi-inst requested review from rh12 and szabinst September 25, 2024 14:21

Merge branch 'master' into bugfix/Xcode16-Fixes

25d13ee

suhaibabsi-inst and others added 8 commits October 2, 2024 10:42

Merge branch 'master' into bugfix/Xcode16-Fixes

e657b2e

Merge branch 'master' into bugfix/Xcode16-Fixes

90ee473

Merge branch 'master' into bugfix/Xcode16-Fixes

3957722

Fix code level warnings.

6a65e77

Enable build by dependency order in schemes and remove no longer exis…

fffd0dd

…ting targets.

Merge branch 'master' into bugfix/Xcode16-Fixes

70fcf68

# Conflicts: # Core/Core/ObserverAlerts/GetObserverAlerts.swift

Fix new warnings after merge.

fed9340

Add legacy flag to xcresulttool invocation.

ffabdc7

vargaat requested a review from ndrsszsz as a code owner October 21, 2024 12:55

vargaat added 3 commits October 21, 2024 15:24

Move --legacy to the last parameter entry.

c5daa17

Bump XCResultKit to the latest version.

5559e31

Update min MacOS version for swift scripts.

d0907b1

vargaat added 3 commits October 21, 2024 16:51

Update cookie tests.

b619cda

Use new app badge setter API. Update badge tests to wait for async ba…

50e9755

…dge updates.

Fix swift script compilation error and warnings.

c8b8ed4

suhaibabsi-inst assigned vargaat and unassigned suhaibabsi-inst Oct 21, 2024

vargaat added 6 commits October 22, 2024 09:54

Update badge controller.

72be0ae

Update assignment picker test.

f1751f5

Fix test webview configuration not copying test data.

f770c7e

Update cookie related test in parent.

7b9d013

refs: MBL-17890 affects: Student, Teacher, Parent release note: none test plan:

Fix warning in audiopicker. Enable user script sandboxing on Core and…

0f3c528

… TestsFoundation projects.

- Enable user script sandboxing in student, teacher and parent projects.

e04ac15

- Update projects to recommended settings. - Add reverse relationship to Quiz

rh12 reviewed Oct 24, 2024

View reviewed changes

vargaat added 3 commits October 24, 2024 10:51

Fix code review findings. Update localized string files.

57d81e9

Fix font name typo in plist files.

70b8d62

Fix storyboard trying to directly load font.

e23aff1

szabinst previously approved these changes Oct 24, 2024

View reviewed changes

Fix "Could not materialize Objective-C class named UIKit" error by re…

1f7bab7

…moving the custom class name from the database model.

vargaat dismissed szabinst’s stale review via 1f7bab7 October 24, 2024 09:49

rh12 previously approved these changes Oct 24, 2024

View reviewed changes

Fix CoreData warning during testing: no NSValueTransformer with class…

82436b3

… name found.

vargaat dismissed rh12’s stale review via 82436b3 October 24, 2024 09:53

rh12 approved these changes Oct 24, 2024

View reviewed changes

vargaat merged commit 17f75e0 into master Oct 24, 2024
3 of 4 checks passed

vargaat deleted the bugfix/Xcode16-Fixes branch October 24, 2024 11:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix issues of Xcode 16 #2899

Fix issues of Xcode 16 #2899

Uh oh!

suhaibabsi-inst commented Sep 24, 2024

Uh oh!

inst-danger commented Sep 24, 2024 •

edited

Loading

Uh oh!

szabinst commented Sep 25, 2024

Uh oh!

suhaibabsi-inst commented Sep 25, 2024

Uh oh!

szabinst commented Sep 25, 2024

Uh oh!

rh12 left a comment

Uh oh!

Uh oh!

Uh oh!

suhaibabsi-inst commented Sep 30, 2024

Uh oh!

rh12 left a comment

Uh oh!

rh12 Oct 24, 2024

Uh oh!

szabinst left a comment

Uh oh!

rh12 left a comment

Uh oh!

Uh oh!

Uh oh!

	public func equalsProperties(to anotherCookie: HTTPCookie?) -> Bool {
	public func isEqualProperties(to anotherCookie: HTTPCookie?) -> Bool {

Fix issues of Xcode 16 #2899

Fix issues of Xcode 16 #2899

Uh oh!

Conversation

suhaibabsi-inst commented Sep 24, 2024

Checklist

Uh oh!

inst-danger commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

szabinst commented Sep 25, 2024

Uh oh!

suhaibabsi-inst commented Sep 25, 2024

Uh oh!

szabinst commented Sep 25, 2024

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

suhaibabsi-inst commented Sep 30, 2024

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

rh12 Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

szabinst left a comment

Choose a reason for hiding this comment

Uh oh!

rh12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

inst-danger commented Sep 24, 2024 •

edited

Loading