Skip to content

feat(vdp): remove ResponseComponent and merge it into TriggerByRequest #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

feat(vdp): remove ResponseComponent and merge it into TriggerByRequest #302

merged 2 commits into from
Apr 15, 2024

Conversation

donch1989
Copy link
Member

Because

  • The ResponseComponent is highly coupled with TriggerByRequest. We should put them together

This commit

  • Merges ResponseComponent into TriggerByRequest message.

@linear Linear
Copy link

linear bot commented Apr 15, 2024

INS-4169 retire "start component" and add "request trigger"

@donch1989 donch1989 merged commit f9a884b into main Apr 15, 2024
@donch1989 donch1989 deleted the huitang/ins-4169-2 branch April 15, 2024 14:55
@droplet-bot droplet-bot mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu Awaiting requested review from heiruwu

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donch1989 @droplet-bot