-
Notifications
You must be signed in to change notification settings - Fork 89
CHEF-19255 Fix named pipes to be more secure #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sa-progress
wants to merge
10
commits into
main
Choose a base branch
from
CHEF-19255-inspec-bugcrowd-chef-privilege-escalation-vulnerability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CHEF-19255 Fix named pipes to be more secure #797
sa-progress
wants to merge
10
commits into
main
from
CHEF-19255-inspec-bugcrowd-chef-privilege-escalation-vulnerability
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sa-progress <[email protected]>
Signed-off-by: sa-progress <[email protected]>
Signed-off-by: sa-progress <[email protected]>
Signed-off-by: sa-progress <[email protected]>
Signed-off-by: sa-progress <[email protected]>
Signed-off-by: sa-progress <[email protected]>
Signed-off-by: sa-progress <[email protected]>
sathish-progress
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances security for Windows named pipes in the local transport by enforcing ACLs, verifying ownership, and adding corresponding tests.
- Enforce ownership checks before pipe connection and raise on unauthorized access
- Configure strict pipe ACLs in PowerShell when starting the server
- Introduce
current_windows_user
andpipe_owned_by_current_user?
helpers with new tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
test/windows/local_test.rb | Added specs for pipe ownership and Windows user detection logic |
lib/train/transports/local.rb | Enforce ACL checks, set pipe security rules, and add helper methods |
Comments suppressed due to low confidence (1)
lib/train/transports/local.rb:236
- Consider adding a unit test to cover the unauthorized access path in
acquire_pipe
, ensuring thatPipeError
is raised when the current user does not own the pipe.
raise PipeError, "Unauthorized user '#{current_user}' tried to connect to pipe '#{pipe_name}'. Pipe is owned by '#{owner}'."
Co-authored-by: Copilot <[email protected]>
Signed-off-by: sa-progress <[email protected]>
Nik08
approved these changes
Jun 19, 2025
…5-inspec-bugcrowd-chef-privilege-escalation-vulnerability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements security best practices for Windows named pipe usage in the local transport.
Related Issue
Types of changes
Checklist