Skip to content

Update the reproducibility section of "Including Data in teal Applications" vignette's #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes #1543

  • Updates the screenshots
  • I rewrote the section about reproducibility and verification. I expanded how teal_data objects work but I mention how the unverified object affects the (teal) application.

@llrs-roche llrs-roche added the core label Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Unit Tests Summary

  1 files   26 suites   2m 0s ⏱️
272 tests 226 ✅ 46 💤 0 ❌
468 runs  422 ✅ 46 💤 0 ❌

Results for commit 2abd035.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💚 $165.33$ $-65.91$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
module_teal 💚 $2.60$ $-1.01$ appends_added_duplicated_slice_and_makes_new_slice_id_unique
module_teal 💚 $4.62$ $-1.90$ appends_new_slice_and_activates_in_global_filters_when_added_in_a_module_if_module_specific
module_teal 💚 $3.84$ $-1.62$ appends_new_slice_and_activates_in_module_when_added_in_a_module_if_module_specific
module_teal 💚 $2.86$ $-1.28$ are_receiving_reactive_data_which_triggers_on_change
module_teal 💚 $3.10$ $-1.05$ change_in_the_slicesGlobal_causes_module_s_data_filtering
module_teal 💚 $3.66$ $-1.79$ clicking_reset_button_restores_initial_filters_state_when_module_specific
module_teal 💚 $5.30$ $-2.54$ clicking_reset_button_restores_initial_filters_with_respect_to_mapping_state_when_module_specific
module_teal 💚 $4.59$ $-1.84$ deactivates_in_global_filters_when_removed_from_module_if_module_specific
module_teal 💚 $3.99$ $-1.65$ deactivates_in_module_when_removed_from_module_if_module_specific
module_teal 💚 $3.34$ $-1.72$ displays_parent_s_Subjects_with_count_based_on_primary_key
module_teal 💚 $2.16$ $-1.02$ does_not_receive_transformator_datasets_not_specified_in_transform_datanames_nor_modue_datanames
module_teal 💚 $2.84$ $-1.44$ evaluates_custom_qenv_call_after_filter_is_applied
module_teal 💚 $3.06$ $-1.23$ is_reactive_to_the_filter_changes
module_teal 💚 $2.57$ $-1.19$ multiple_datanames_with_all_and_.raw_data_
module_teal 💚 $2.64$ $-1.35$ pauses_when_transformator_throws_validation_error
module_teal 💚 $2.59$ $-1.31$ receives_all_possible_objects_while_those_not_specified_in_module_datanames_are_unfiltered
module_teal 💚 $2.33$ $-1.12$ receives_all_raw_datasets_based_on_module_datanames
module_teal 💚 $2.00$ $-1.07$ returns_no_rows_if_no_filters_set
module_teal 💚 $4.98$ $-2.19$ sets_filters_from_mapping_global_filters_to_all_modules_FilteredData_when_module_specific
module_teal 💚 $4.80$ $-2.15$ sets_filters_from_mapping_mod_to_all_modules_FilteredData_when_module_specific
module_teal 💚 $3.73$ $-1.49$ sets_filters_from_mapping_mod_to_module_s_FilteredData_when_module_specific
module_teal 💚 $3.81$ $-1.36$ slices_in_slicesGlobal_and_in_FilteredData_refer_to_the_same_object

Results for commit c038514

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  67      11  83.58%   46, 48, 90-98
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                            142      96  32.39%   137-158, 188-196, 206-231, 234-235, 242-251, 254-263, 266-275, 279-289, 291
R/landing_popup_module.R             34      34  0.00%    22-57
R/module_bookmark_manager.R         161     130  19.25%   47-68, 88-142, 147-148, 160, 207, 242-319
R/module_data_summary.R             177      10  94.35%   25-26, 40, 50, 205, 236-240
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 74       0  100.00%
R/module_nested_tabs.R              321     172  46.42%   40-212, 244, 269-271, 377-380, 384-387, 391-394, 443
R/module_session_info.R              18       7  61.11%   35-41
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 303-317, 320-331, 334-340, 354
R/module_teal_data.R                149      76  48.99%   43-149
R/module_teal_lockfile.R            131      69  47.33%   33-37, 45-57, 60-62, 76, 86-88, 92-96, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186, 196-201
R/module_teal_with_splash.R          33      33  0.00%    24-61
R/module_teal.R                     153      51  66.67%   50-101, 118, 132-133, 172
R/module_transform_data.R           116       7  93.97%   20, 46, 130-134
R/modules.R                         285      53  81.40%   174-178, 233-236, 360-380, 388, 394, 571-577, 590-598, 613-628, 674, 687
R/reporter_previewer_module.R        19       1  94.74%   34
R/show_rcode_modal.R                 23      23  0.00%    17-41
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 20       0  100.00%
R/teal_data_utils.R                  10       0  100.00%
R/teal_modifiers.R                   71      71  0.00%    26-214
R/teal_reporter.R                    70       8  88.57%   69, 77-82, 131-132, 135, 152
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   385     385  0.00%    57-776
R/utils.R                           250      38  84.80%   400-449
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   118-406
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3552    1559  56.11%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  -------
R/module_teal_lockfile.R        0     +14  -10.69%
TOTAL                           0     +14  -0.39%

Results for commit: 2abd035

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vignette]: Update Reproducibility section
1 participant