-
-
Notifications
You must be signed in to change notification settings - Fork 2
WIP - Rewrite reporter code in modules #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Code Coverage Summary
Diff against main
Results for commit: e7d0f45 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary1 files 1 suites 1m 40s ⏱️ Results for commit 11a67a2. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit ec17d6d ♻️ This comment has been updated with latest results. |
Signed-off-by: Marcin <[email protected]>
Signed-off-by: Marcin <[email protected]>
Signed-off-by: Marcin <[email protected]>
Signed-off-by: Marcin <[email protected]>
Signed-off-by: Marcin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All examples could save and load the report. Good job!
Sorry for the late review!
Probably not addressable here but when rendering the reports for the examples when saving and loading a report I see:
Quitting from report.Rmd:58-60 [unnamed-chunk-5]
Render document error: Error in `gzfile()`:
! cannot open the connection
The lines where the unnamed chunk 5 is change depending on the module but it remains stable.
However, I could see the report loaded correctly.
Fixes #342