Skip to content

WIP - Rewrite reporter code in modules #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

WIP - Rewrite reporter code in modules #353

wants to merge 18 commits into from

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jul 7, 2025

Fixes #342

@m7pr m7pr added the core label Jul 7, 2025
Copy link
Contributor

github-actions bot commented Jul 7, 2025

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------------------------------------------------------
R/tm_g_gh_boxplot.R                        309      27  91.26%   358, 364, 492-499, 503-504, 545-560, 566-569
R/tm_g_gh_correlationplot.R                532     532  0.00%    229-896
R/tm_g_gh_density_distribution_plot.R      242     242  0.00%    136-452
R/tm_g_gh_lineplot.R                       519     519  0.00%    163-801
R/tm_g_gh_scatterplot.R                    221     221  0.00%    144-445
R/tm_g_gh_spaghettiplot.R                  292     292  0.00%    196-590
R/toggleable_slider.R                      112       7  93.75%   140-146
R/utils-arbitrary_lines.r                  121      14  88.43%   60, 71-74, 78, 90-93, 107, 111, 118, 122
R/utils-data_constraints.r                 189      61  67.72%   39, 57, 111-124, 126-140, 154, 175, 181, 200-226, 241-250
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          68      19  72.06%   2-9, 41-44, 74-80
R/utils.R                                   42      33  21.43%   5, 39-91
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2658    1978  25.58%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                        -35      -3  -0.02%
R/tm_g_gh_correlationplot.R                -35     -35  +100.00%
R/tm_g_gh_density_distribution_plot.R      -30     -30  +100.00%
R/tm_g_gh_lineplot.R                       -34     -34  +100.00%
R/tm_g_gh_scatterplot.R                    -34     -34  +100.00%
R/tm_g_gh_spaghettiplot.R                  -27     -27  +100.00%
TOTAL                                     -195    -163  +0.63%

Results for commit: e7d0f45

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Unit Tests Summary

1 files  1 suites   1m 40s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
9 runs  9 ✅ 0 💤 0 ❌

Results for commit 11a67a2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_g_gh_boxplot 💔 $96.87$ $+3.50$ $0$ $0$ $0$ $0$

Results for commit ec17d6d

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche self-assigned this Jul 11, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All examples could save and load the report. Good job!
Sorry for the late review!

Probably not addressable here but when rendering the reports for the examples when saving and loading a report I see:

Quitting from report.Rmd:58-60 [unnamed-chunk-5]
Render document error: Error in `gzfile()`:
! cannot open the connection

The lines where the unnamed chunk 5 is change depending on the module but it remains stable.
However, I could see the report loaded correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite reporter code in modules
2 participants