Skip to content

284 add callback for DT::datable to hide AJAX warnings #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Oct 1, 2024

Solution for #284 that do not pop-up AJAX warnings from JavaScript DataTable when computations happens too often and rendering is behind the state of the data.

This adds a callback behavior for DT::datatable. We also tested the global setup of this behavior in teal but we were unable to include javascript in a way that it is executed after the object is created. Other modules in other packages don't really need that as they have better reactivity handling. The modules in teal.goshawk have very much reactivitiy and could be refactored one day but that's a bigger project.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        358     358  0.00%    175-600
R/tm_g_gh_correlationplot.R                558     558  0.00%    227-894
R/tm_g_gh_density_distribution_plot.R      282     282  0.00%    135-467
R/tm_g_gh_lineplot.R                       565     565  0.00%    161-820
R/tm_g_gh_scatterplot.R                    248     248  0.00%    144-444
R/tm_g_gh_spaghettiplot.R                  318     318  0.00%    194-593
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         29      29  0.00%    9-45
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          48      48  0.00%    2-73
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2935    2935  0.00%

Diff against main

Filename                                 Stmts    Miss  Cover
-------------------------------------  -------  ------  --------
R/tm_g_gh_boxplot.R                         +6      +6  +100.00%
R/tm_g_gh_correlationplot.R                 +3      +3  +100.00%
R/tm_g_gh_density_distribution_plot.R       +3      +3  +100.00%
R/tm_g_gh_scatterplot.R                     +3      +3  +100.00%
R/tm_g_gh_spaghettiplot.R                   +3      +3  +100.00%
TOTAL                                      +18     +18  +100.00%

Results for commit: b37c0de

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr merged commit 5be3eb2 into main Oct 2, 2024
24 of 25 checks passed
@m7pr m7pr deleted the 284_callback@main branch October 2, 2024 07:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants