Skip to content

Adds some tests to use_evaluate feature branch and avoids deprecated function #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

averissimo
Copy link
Contributor

Changes description

  • Remove intermediate plots by default
  • Avoids deprecated function in testthat 3rd edition
  • Adds some tests
    • Q: Does the S4 test make sense?

@averissimo averissimo changed the title tests: adds some tests and avoids deprecated function Adds some tests to use_evaluate feature branch and avoids deprecated function Jun 25, 2025
@averissimo averissimo requested a review from gogonzo June 26, 2025 09:58
testthat::it("intermediate plots are not kept", {
q <- qenv()
q1 <- eval_code(q, expression(plot(1:10), title("A title")))
testthat::expect_length(get_outputs(q1), 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@averissimo averissimo merged commit 4858a08 into use_evaluate Jun 26, 2025
1 check passed
@averissimo averissimo deleted the update_to_some_tests@use_evaluate branch June 26, 2025 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants