Skip to content

breaking: Clearer feature flags #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Jun 26, 2025

Addresses comments from #45 (comment)

Hi @emmanuelsdias -are you able to test these new features on your workflows? You can use the branch instead of the version tag (breaking/clearer-feature-flags)

Once we test this on our end and if it looks good on your end, we can create a major release out of this (since the "legacy" feature flags will be retained in the older major release).

@cicdguy cicdguy self-assigned this Jun 26, 2025
@cicdguy cicdguy requested a review from a team as a code owner June 26, 2025 22:55
Copy link

github-actions bot commented Jun 26, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Jun 26, 2025

badge

Code Coverage Summary (test-no-branch.xml)

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------
Main.java                            11       0  100.00%
search/BinarySearch.java             12       1  91.67%   24
search/ISortedArraySearch.java        0       0  100.00%
search/LinearSearch.java              7       2  71.43%   19-24
TOTAL                                30       3  90.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 966779e

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented Jun 26, 2025

badge

Code Coverage Summary (togglable report, excluded details)

Results for commit: 966779e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented Jun 26, 2025

badge

Code Coverage Summary (test-missing-lines.xml) without detailed coverage

Results for commit: 966779e

Minimum allowed coverage is 50%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented Jun 26, 2025

badge

Code Coverage Summary (test-no-branch.xml) without detailed coverage

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 966779e

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented Jun 26, 2025

badge

Code Coverage Summary (comprehensive test)

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------
file1_high_coverage.py         10       1  90.00%   9
file2_medium_coverage.py       10       4  60.00%   3-4, 7-8
file3_low_coverage.py          10       7  30.00%   2-4, 6-8, 10
TOTAL                          30      12  75.00%

Results for commit: 966779e

Minimum allowed coverage is 70%

♻️ This comment has been updated with latest results

Copy link

github-actions bot commented Jun 26, 2025

badge

Code Coverage Summary (test-missing-lines.xml)

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  ---------------
all_lines_covered.py       10       0  100.00%
miss_at_start.py           10       2  80.00%   1-3
miss_at_end.py             10       2  80.00%   9-10
single_line_gaps.py        10       3  70.00%   3, 5, 9
multi_line_gaps.py         10       7  30.00%   4-5, 7-9, 15-18
unsorted_lines.py          10       5  50.00%   4, 3, 8-9, 6
no_lines.py                 0       0  0.00%
single_line.py              1       1  0.00%    4
TOTAL                      61      20  51.25%

Results for commit: 966779e

Minimum allowed coverage is 50%

♻️ This comment has been updated with latest results

@cicdguy
Copy link
Contributor Author

cicdguy commented Jun 26, 2025

I have read the CLA Document and I hereby sign the CLA

@emmanuelsdias
Copy link
Contributor

I'll test this later tonight, I'll update here once it's done. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants