-
-
Notifications
You must be signed in to change notification settings - Fork 1
Remove lookup-refs #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lookup-refs #815
Conversation
✅ All contributors have signed the CLA |
Unit Tests Summary 1 files 58 suites 3m 18s ⏱️ Results for commit 6f2150a. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 5ff378b ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All packages removed from lookup-refs are already on CRAN for the version the package depends on. I don't see any cardx or card dependency that might require using Remotes
field.
Remember to accept the CLA.
hi @m7pr and @llrs-roche please don't merge this in until #813 is complete, there is on-going release activities on chevron |
hey @shajoezhu no merges are planned, just placeholders with PRs, so we can merge, when every team and every team member understand the benefits |
I have read the CLA Document and I hereby sign the CLA |
blocked by #818 |
Code Coverage Summary
Diff against main
Results for commit: 6f2150a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Part of https://github.com/insightsengineering/coredev-tasks/issues/609
From now on, we will provide development dependencies in
format, so it's explicitly visible in the DESCRIPTION file and can be handled by
pak::install
,renv::install
andremotes::install
.With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.