-
-
Notifications
You must be signed in to change notification settings - Fork 4
Remove lookup-refs #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lookup-refs #264
Conversation
✅ All contributors have signed the CLA |
Unit Tests Summary 1 files 174 suites 1m 12s ⏱️ Results for commit 7410496. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 444da53 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 7410496 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Delighted to see this change coming through in more places! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Daniel's comment we need to keep Remotes till new cards version is released
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but not sure if we can merge yet.
Let's don't merge. This is just a part of the changes. Other one will come with this insightsengineering/nestdevs-tasks#103 |
Signed-off-by: Lluís Revilla <[email protected]>
Part of https://github.com/insightsengineering/coredev-tasks/issues/609
From now on, we will provide development dependencies in
format, so it's explicitly visible in the DESCRIPTION file and can be handled by
pak::install
,renv::install
andremotes::install
.With development dependencies specified in CJ Pipelines configuration, this connection was hidden, and it was hard to install the package from the main branch (or any other branch) locally from user's machine.