Fix building docker image #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGLO
force-pushed
the
fix-building-docker-image
branch
from
487251f to
d08b3ae
Compare
|
a9e1cc5 |
I think there is more in my PR:
|
neotheprogramist
approved these changes
Jun 30, 2025
iquerejeta
pushed a commit
that referenced
this pull request
Jul 21, 2025
Klapeyron
pushed a commit
that referenced
this pull request
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revives building docker image locally. Build image was tested on arm64 Mac - Docker Desktop with Rosetta enabled and on linux with AMD CPU.
On a rebuild, extra time spend for building docker images is less than recompilation of runtime and node crates alone. We can test our changes in local-environment every few minutes now