Skip to content

feat: rename sidechain pub key and signature to partner-chain pub key and signature in register1 and register2 wizards #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

feat: rename sidechain pub key and signature to partner-chain pub key and signature in register1 and register2 wizards #878

merged 3 commits into from
Jun 30, 2025

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Jun 26, 2025 •
edited
Loading

Description

Continues rename of sidechain to partner-chain, this time in registration wizards.

Ref: ETCM-9970

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • The size limit of 400 LOC isn't needlessly exceeded
  • The PR refers to a JIRA ticket (if one exists)
  • New tests are added if needed and existing tests are updated.
  • New code is documented and existing documentation is updated.
  • Relevant logging and metrics added
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@LGLO LGLO force-pushed the etcm-9770-wizards-register2-cmd-line-parameters-names branch from d124416 to 5318d25 Compare June 26, 2025 10:41
AmbientTea
AmbientTea approved these changes Jun 27, 2025
View reviewed changes
LGLO and others added 2 commits June 30, 2025 08:41
@LGLO LGLO force-pushed the etcm-9770-wizards-register2-cmd-line-parameters-names branch from f537c3d to d2e69d3 Compare June 30, 2025 06:41
@LGLO LGLO enabled auto-merge (squash) June 30, 2025 06:41
@LGLO LGLO disabled auto-merge June 30, 2025 07:42
@LGLO LGLO enabled auto-merge (squash) June 30, 2025 07:42
@LGLO LGLO merged commit 8589b3a into master Jun 30, 2025
37 checks passed
@LGLO LGLO deleted the etcm-9770-wizards-register2-cmd-line-parameters-names branch June 30, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmbientTea AmbientTea AmbientTea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LGLO @AmbientTea