feat: add automatic-generate-keys command to partner-chains CLI #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladamesny
commented
Jun 18, 2025
| @@ -40,6 +41,9 @@ plutus-datum-derive = { workspace = true } | |||
| ed25519-zebra = { workspace = true } | |||
| sp-session-validator-management = { workspace = true, features = ["std"] } | |||
| pallet-session-validator-management = { workspace = true, features = ["std"] } | |||
| subxt = "0.35" | |||
There was a problem hiding this comment.
Put these on the main cargo.toml on top level - use the workspace syntax { workspace = true }
ladamesny
commented
Jun 18, 2025
| #[derive(Debug, Serialize, Deserialize)] | ||
| pub struct SessionKeyInfo { | ||
| pub key_type: String, | ||
| pub key_type_bytes: String, |
There was a problem hiding this comment.
we don't need key_type_bytes
ladamesny
commented
Jun 18, 2025
| // Step 1: Generate keys using author_rotateKeys RPC via jsonrpsee | ||
| context.eprint("⚙️ Calling author_rotateKeys() RPC method..."); | ||
|
|
||
| let rpc_client = HttpClientBuilder::default() |
There was a problem hiding this comment.
May not need this - use subxt api
ladamesny
commented
Jun 18, 2025
| .build(&config.node_url) | ||
| .context("Failed to build RPC client")?; | ||
|
|
||
| let keys_hex: String = rpc_client |
There was a problem hiding this comment.
Same here - use subxt (online client)
Klapeyron
reviewed
Jun 23, 2025
| .context("Failed to connect to node")?; | ||
|
|
||
| context.eprint("✅ Connected to node successfully"); | ||
| context.eprint("🔍 Extracting SessionKeys type definition from runtime metadata..."); |
There was a problem hiding this comment.
this step is not needed anymore. We can get ready list by invoking RPC command on the node
Klapeyron
reviewed
Jun 23, 2025
Comment on lines
128
to
139
| // Step 2: Decode the keys using the extracted type information | ||
| context.eprint("🔍 Decoding session keys using runtime type information..."); | ||
|
|
||
| let decoded_keys = decode_session_keys_from_type_info(&keys_hex, &session_keys_type_info) | ||
| .context("Failed to decode session keys using type information")?; | ||
|
|
||
| context.eprint(&format!("✅ Successfully decoded {} session keys:", decoded_keys.len())); | ||
| for (key_type, key_bytes) in &decoded_keys { | ||
| let key_type_str = String::from_utf8_lossy(key_type); | ||
| let key_hex = format!("0x{}", hex::encode(key_bytes)); | ||
| context.eprint(&format!(" • {} key: {}", key_type_str, key_hex)); | ||
| } |
There was a problem hiding this comment.
as above, decoding will be done by the node, we have to convert the output to our internal output
Klapeyron
reviewed
Jun 23, 2025
Comment on lines
121
to
124
| let keys_hex = context | ||
| .run_command(&format!("{node_executable} rpc author_rotateKeys --url {}", config.node_url))? | ||
| .trim() | ||
| .to_string(); |
There was a problem hiding this comment.
we should use some client module for execution of RPC calls
Klapeyron
requested changes
Jun 23, 2025
Comment on lines
147
to
56
| /// Extract the actual SessionKeys type definition from runtime metadata | ||
| /// This is truly runtime-aware - it reads the actual type definition | ||
| fn extract_session_keys_type_from_metadata( | ||
| metadata: &subxt::Metadata, | ||
| ) -> Result<Vec<SessionKeyTypeInfo>> { | ||
| // Look for the SessionKeys type in the metadata | ||
| let session_keys_type = find_session_keys_type(metadata) | ||
| .context("SessionKeys type not found in runtime metadata")?; | ||
|
|
||
| // Parse the SessionKeys type definition | ||
| parse_session_keys_type(session_keys_type, metadata) | ||
| } |
There was a problem hiding this comment.
this will be done by the node, we don't need it anymore
| parse_session_keys_type(session_keys_type, metadata) | ||
| } | ||
|
|
||
| /// Find the SessionKeys type in the metadata by looking at type paths |
There was a problem hiding this comment.
I guess that all the below lines are not needed then
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
from
d21fec0 to
ddf2921
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
from
cd4b818 to
2654c45
Compare
Klapeyron
reviewed
Jun 26, 2025
Klapeyron
reviewed
Jun 26, 2025
|
|
||
| let mut session_keys = Vec::new(); | ||
| let mut offset = 0; | ||
| let key_types = ["aura", "gran", "imon", "auth"]; |
There was a problem hiding this comment.
this code still assumes key types
Klapeyron
reviewed
Jun 26, 2025
|
|
||
| /// Parse session keys from hex string by splitting into common key lengths | ||
| /// Substrate session keys are typically concatenated public keys of fixed lengths | ||
| fn parse_session_keys_hex<C: IOContext>(keys_hex: &str, context: &C) -> Vec<SessionKeyInfo> { |
There was a problem hiding this comment.
we should not parse anything, it is already done by the node
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
5 times, most recently
from
8ad297f to
ea3b076
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
2 times, most recently
from
a35816b to
c85315d
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
from
bbbb6ec to
7663893
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
from
7663893 to
8b38ac2
Compare
ladamesny
force-pushed
the
feat/automatic-generate-keys
branch
from
8b38ac2 to
9cffa3f
Compare
|
Replaced by this PR: https://github.com/input-output-hk/partner-chains/pull/924/files |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overview
Added a new automatic-generate-keys command that automatically generates session keys by connecting to a running Partner Chain node via RPC, eliminating the need for manual key generation and parsing. Jira Ticket ETCM-11971
Implementation Details
Command Structure:
Uses a clean two-RPC-call approach:
Key Benefits:
✅ No assumptions - Node provides actual key types (e.g., "gran", "imon", "aura")
✅ Runtime-agnostic - Works with any SessionKeys configuration
✅ No manual parsing - Node handles all SCALE decoding internally
✅ Always accurate - Impossible to get key order wrong
Checklist
changelog.mdfor affected crate