feat(staking): [LW-8877] Add activity tab to staking, show rewards list #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi93
changed the base branch from
main
to
feat/lw-8751-show-pool-rewards-in-activity
refi93
force-pushed
the
feat/lw-8877-staking-activity-rewards
branch
2 times, most recently
from
0340060 to
7fea290
Compare
refi93
changed the title
Base automatically changed from
feat/lw-8751-show-pool-rewards-in-activity
to
main
October 30, 2023 09:11
refi93
force-pushed
the
feat/lw-8877-staking-activity-rewards
branch
from
40495e0 to
2d1b7b2
Compare
refi93
force-pushed
the
feat/lw-8877-staking-activity-rewards
branch
4 times, most recently
from
c0f823e to
62528d4
Compare
… used by staking activity
refi93
force-pushed
the
feat/lw-8877-staking-activity-rewards
branch
from
62528d4 to
483284e
Compare
refi93
commented
Nov 3, 2023
| @@ -44,7 +44,7 @@ export const StakingView = () => { | |||
| </Box> | |||
| <Navigation> | |||
| {(activePage) => ( | |||
| <Box mt="$40"> | |||
| <Box mt="$40" h="$fill"> | |||
There was a problem hiding this comment.
This makes the "Activity" page (and any other "Staking" tab) container fill the available vertical space, which in turns allows me to align vertically to the center the "No staking activity yet" component. TBH I find this a bit fragile as the code lacks any clear connection and therefore it's easy to break. Do you perhaps have some nicer solution on your mind @mrcnk ?
refi93
changed the title
greatertomi
pushed a commit
that referenced
this pull request
Nov 16, 2023
* feat(staking): add activity tab * feat(staking): [LW-8877] Add activity tab to staking, show rewards list (#684) * feat(staking): add rewards list to Staking Activity tab * feat(staking): expose activity detail drawer in staking section to be used by staking activity * feat(staking): add "no staking activity yet" screen * fix(staking): align "no staking activity" component to center vertically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Add new tab to Staking section called "Activities" and add there the "History" section as shown in designs
This PR also adds the screen for the scenario where the user has no staking activity yet
see figma designs in JIRA issue
Testing
Go to
Staking->Activity, check that the events are properly shown and that correct details appear when you click on an event.Screenshots
Allure report
allure-report-publishergenerated test report!smokeTests: ❌ test report for 7fea2909