feat(cat-voices): DocumentType list value #2571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Test Report | |
damian-molinski
changed the title
damian-molinski
changed the title
damian-molinski
added
do not merge yet
dt-iohk
reviewed
May 19, 2025
.../packages/internal/catalyst_voices_repositories/lib/src/dto/api/document_index_list_dto.dart
Show resolved
Hide resolved
10 tasks
8 tasks
…/catalyst-voices into feat/multi_type_document
* fix(cat-gateway): modify doc type Signed-off-by: bkioshn <[email protected]> * fix(cat-gateway): change from list string to list uuid Signed-off-by: bkioshn <[email protected]> * fix(cat-gateway): remove unused func in doctype Signed-off-by: bkioshn <[email protected]> * fix(cat-gateway): use old doctype Signed-off-by: bkioshn <[email protected]> * fix(cat-gateway): use impl array for doctype Signed-off-by: bkioshn <[email protected]> * fix(cat-gateway): improve doctype Signed-off-by: bkioshn <[email protected]> --------- Signed-off-by: bkioshn <[email protected]>
damian-molinski
added
squad: gatekeepers
|
DO NOT MERGE this feature Once this feature can be merged, the following task need to be done before merge.
|
…/catalyst-voices into feat/multi_type_document
stevenj
requested changes
Jul 10, 2025
| CREATE TABLE IF NOT EXISTS signed_docs ( | ||
| id UUID NOT NULL, -- UUID v7 | ||
| ver UUID NOT NULL, -- UUID v7 | ||
| type UUID NOT NULL, -- UUID v4 | ||
| type UUID [] NOT NULL, -- List of UUID v4 |
There was a problem hiding this comment.
NAK. Can't change schema like this. Requires a V3_update_signed_docs.sql which performs a table modification of this one column. And it needs to be able to migrate the data.
damian-molinski
added
the
no-track
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accepts
CoseHeaders.typelist value and and convertsDocumentTypeto support a list instead of single value.Based on specs (link)
Related Issue(s)
Resolves #2579
Description of Changes
Converts
DocumentTypeenum into class for supporting multiple values.Note. note enum so we can supporty partially known types or dynamic definisions.
Breaking changes
FE will start sending type as
CborListso backend have to be ready.Related PRs
BE:
input-output-hk/catalyst-libs#338
input-output-hk/catalyst-libs#356
Please confirm the following checks