Skip to content

feat(rust/signed-doc): signed doc metadata serde refactoring #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 20, 2025
Merged

feat(rust/signed-doc): signed doc metadata serde refactoring #372

merged 9 commits into from
Jun 20, 2025
+133 −111

Conversation

no30bit
Copy link
Contributor

@no30bit no30bit commented Jun 20, 2025

Description

Removes InnerMetdata. Maintains serde::Deserialize impl. Extends Metadata api with from_fields constructor.

Related Issue(s)

Closes #366

Description of Changes

  • Remove InnerMetadata.
  • Implement Serialize for supported_field types.
  • Implement Metadata::from_json – replacing previous impl with InnerMetadata.
  • Add Metadata::from_fields that does the same as Metadata::from_metadata_fields used to do, but accepts a vector of SupportedField.

Breaking Changes

No.

Related Pull Requests

#338

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@no30bit no30bit requested review from Mr-Leshiy, bkioshn and cong-or June 20, 2025 03:40
@no30bit no30bit self-assigned this Jun 20, 2025
@no30bit no30bit added this to Catalyst Jun 20, 2025
@no30bit no30bit added enhancement New feature or request review me PR is ready for review backend Task could/should be picked up as work on the backend. labels Jun 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 351/351}$ | ${\color{red}Fail: 0/351}$ |

Mr-Leshiy
Mr-Leshiy requested changes Jun 20, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from New to 🔖 Ready in Catalyst Jun 20, 2025
@no30bit no30bit requested a review from Mr-Leshiy June 20, 2025 12:23
@no30bit no30bit moved this from 🔖 Ready to 👀 In review in Catalyst Jun 20, 2025
Mr-Leshiy
Mr-Leshiy approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 8d6b5c9 into feat/new-cat-signed-doc Jun 20, 2025
42 of 45 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/new-cat-signed-doc-metadata-serde branch June 20, 2025 12:31
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jun 20, 2025
Mr-Leshiy added a commit that referenced this pull request Jul 31, 2025
@bkioshn @Mr-Leshiy
@apskhem @no30bit @cong-or @saibatizoku @stevenj
feat(rust/signed-doc): Implement new Catalyst Signed Doc (#338)
61381e4 
* chore: add new line to open pr

Signed-off-by: bkioshn <[email protected]>

* chore: revert

Signed-off-by: bkioshn <[email protected]>

* feat(rust/signed-doc): add new type `DocType` (#339)

* feat(signed-doc): add new type DocType

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add conversion policy

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): doc type

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): doc type error

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): seperate test

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): format

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>

* feat(rust/signed-doc): Add initial decoding tests for the Catalyst Signed Documents (#349)

* wip

* wip

* fix fmt

* fix spelling

* fix clippy

* fix(rust/signed-doc): Apply new `DocType` (#347)

* feat(signed-doc): add new type DocType

Signed-off-by: bkioshn <[email protected]>

* wip: apply doctype

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add more function to DocType

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): map old doctype to new doctype

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add eq to uuidv4

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): fix validator

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): minor fixes

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): add hash to uuidv4

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): decoding test

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): doctype

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): minor fixes

Signed-off-by: bkioshn <[email protected]>

* chore(sign-doc): fix comment

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): add fromstr to uuidv4 and 7

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): restructure doctypes

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): test

Signed-off-by: bkioshn <[email protected]>

* Update rust/signed_doc/tests/proposal.rs

* Update rust/signed_doc/tests/comment.rs

* Update rust/signed_doc/tests/submission.rs

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Alex Pozhylenkov <[email protected]>

* fix(rust/signed-doc): Correct CBOR content type and data validation (#350)

* feat: initial

* test: minor check

* test: more test

* fix: minor

* Update rust/signed_doc/src/validator/rules/content_type.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* chore: remove proptest

* chore: cleanup

* chore: split json and cbor

* chore: minor adjustment

* Update rust/signed_doc/src/validator/rules/content_type.rs

Co-authored-by: Artur Helmanau <[email protected]>

* fix: import json raw value

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>
Co-authored-by: Artur Helmanau <[email protected]>

* feat(rust/signed-doc): enum map representation for metadata (#359)

* feat: metadata enum map representation

* add encode/decode impl for Metadata

* fix integer label, upd its doc

* upd integer label doc.

* use ProblemReport, remove map ord decode validation

* Update rust/signed_doc/src/metadata/mod.rs

* feat(rust/signed-doc): Catalyst signed document encoding using minicbor (#353)

* wip

* wip

* wip

* wip

* wip

* fix

* fix clippy

* wip

* cleanup

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* update test

* fix spelling

* wip

* wip

* Update rust/signed_doc/src/lib.rs

Co-authored-by: Artur Helmanau <[email protected]>

* Revert "wip"

This reverts commit 5b209bb.

* fix clippy

---------

Co-authored-by: Artur Helmanau <[email protected]>

* feat(rust/cbork): deterministic map decoding helper (#360)

* feat(deterministic decoder): rfc template

WIP

* fix: implement minimal length validation for string types

Adds validation for minimal length encoding of string types (Str and Bytes) in the
DeterministicDecoder according to RFC 8949 Section 4.2. This ensures that string
lengths are encoded using the minimal number of bytes required. For example, strings
of length 0-23 must use direct encoding, length 24-255 must use one byte, etc.

The changes:
- Add length validation for Type::Str and Type::Bytes
- Check for indefinite length strings
- Validate minimal length encoding using check_minimal_length function

* test: expand deterministic CBOR decoding tests

Adds comprehensive test coverage for RFC 8949 Section 4.2 deterministic encoding
requirements. The new tests verify:

- Minimal length integer encoding rules for values 0-23, 24-255, etc.
- Floating point value requirements including shortest form and non-finite prohibition
- String/array/map length encoding rules and indefinite length checks
- Map key ordering rules with length-first canonical ordering

Each test includes detailed comments explaining:
- The specific RFC requirement being tested
- Byte-level breakdown of CBOR encodings
- Why each test case is valid or invalid
- References to relevant RFC sections

This ensures proper validation of all deterministic encoding rules and helps
maintainers understand the requirements.

* cbor: Add comprehensive tests for deterministic encoding

Add detailed test cases for deterministic CBOR encoding rules as specified in
RFC 8949 section 4.2. The new tests cover:

- Integer boundary conditions and minimal encoding requirements
- Negative integer encoding across different ranges
- Map key ordering (length-first, then lexicographic)
- Floating point encoding with different precision requirements
- String comparison ordering including UTF-8 handling
- Nested structure validation
- Array length encoding rules
- Duplicate map key detection

The tests are extensively documented with RFC requirements and include TODOs
for future validation improvements, particularly for floating point handling
where additional checks for non-finite values and minimal encoding could be
added.

Includes commented-out test cases that can be enabled once support for
validating non-finite floating point values is implemented.

RFC: https://datatracker.ietf.org/doc/html/rfc8949#section-4.2

* cbor: Fix clippy warnings in deterministic tests

Refactor test cases to fix clippy warnings:
- Use simpler iterator chaining in array length test
- Remove redundant  calls
- Replace explicit type annotations with inferred types
- Fix collect() with redundant map operations

Also simplify floating point test cases to match current implementation
and improve RFC 8949 compliance documentation. The floating point tests
now focus on valid encodings while keeping commented-out future test
cases for non-finite values validation.

Tests still verify the same RFC requirements but with more idiomatic
Rust code.

* fmt

* docs

* docs: enhance CBOR deterministic validation documentation

Improve documentation and refactor validate_next() to align with RFC 8949 § 4.2
specification for deterministically encoded CBOR. Split validation logic into
smaller, focused functions for better maintainability.

- Split validate_next into specialized validation functions:
  * validate_integer() - Handles minimal integer encoding
  * validate_array() - Validates definite-length arrays
  * validate_string() - Checks string/bytes encoding
  * validate_map() - Ensures proper key ordering

- Add comprehensive documentation referencing RFC 8949:
  * Detail core deterministic encoding requirements
  * Document rules for integer minimality
  * Explain length field constraints
  * Specify map key ordering rules
  * Include examples of valid/invalid encodings

This refactoring improves code organization while maintaining full compliance
with the CBOR deterministic encoding specification. The enhanced documentation
helps developers understand both implementation details and RFC requirements.

* docs: enhance CBOR deterministic validation documentation

Improve documentation and refactor validate_next() to align with RFC 8949 § 4.2
specification for deterministically encoded CBOR. Split validation logic into
smaller, focused functions for better maintainability.

- Split validate_next into specialized validation functions:
  * validate_integer() - Handles minimal integer encoding
  * validate_array() - Validates definite-length arrays
  * validate_string() - Checks string/bytes encoding
  * validate_map() - Ensures proper key ordering

- Add comprehensive documentation referencing RFC 8949:
  * Detail core deterministic encoding requirements
  * Document rules for integer minimality
  * Explain length field constraints
  * Specify map key ordering rules
  * Include examples of valid/invalid encodings

This refactoring improves code organization while maintaining full compliance
with the CBOR deterministic encoding specification. The enhanced documentation
helps developers understand both implementation details and RFC requirements.

* docs: Add comprehensive documentation for CBOR deterministic validation

* Add violation test cases for string comparison ordering

* Add violation test cases for string comparison ordering

* feat(deterministic cbor): toggle validation

* feat(deterministic cbor): toggle validation

* feat(deterministic cbor): toggle validation

* refactor(generic decoder): helper functions

* refactor(generic decoder): helper functions

* refactor(generic decoder): helper functions

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(deterministic maps): rfc validation

* refactor(minimal length check): maps only

* refactor(minimal length check): maps only

* refactor(minimal length check): maps only

* refactor(minimal length check): maps only

* docs: enhance CBOR deterministic validation documentation

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* feat(deterministic map decoder only): rfc 8949

* refactor(pr changes): houskeeping

* fmt

* refactor(pr changes): houskeeping

* refactor(pr changes): houskeeping

* refactor(pr changes): houskeeping

* refactor(pr changes): houskeeping

* refactor(cleanup): actual vs declared length helper

* refactor(cleanup): actual vs declared length helper

* refactor(cleanup): actual vs declared length helper

* Add comprehensive MapEntry ordering tests

- Test length-first and lexicographic key ordering per RFC 8949
- Verify equality vs ordering distinction for CBOR deterministic encoding
- Cover edge cases: empty keys, identical entries, duplicate key scenarios

* Add comprehensive MapEntry ordering tests

- Test length-first and lexicographic key ordering per RFC 8949
- Verify equality vs ordering distinction for CBOR deterministic encoding
- Cover edge cases: empty keys, identical entries, duplicate key scenarios

* refactor(err): rm deterministic error type

* Update rust/cbork-utils/src/deterministic_helper.rs

Co-authored-by: Artur Helmanau <[email protected]>

* Fix MapEntry ordering to prioritize length over lexicographic comparison

The Ord implementation now compares key_bytes by length first, then
lexicographically if lengths are equal. This fixes the failing test
case where shorter keys should be ordered before longer keys regardless
of byte content.

* Update rust/cbork-utils/src/deterministic_helper.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* Update rust/cbork-utils/src/deterministic_helper.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* Update rust/cbork-utils/src/deterministic_helper.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* fmt

* fmt

* fmt

* refactor(rm fn): get bytes

* refactor(indefinite length items): laconic

* refactor(indefinite length items): laconic

---------

Co-authored-by: Artur Helmanau <[email protected]>
Co-authored-by: Alex Pozhylenkov <[email protected]>

* refactor(rust/signed-doc): Cleanup `Builder`, make `raw_bytes` field non-optional (#369)

* wip

* wip

* wip

* wip

* wip

* cleanup

* wip

* wip

* fix clippy

* fix(rust/signed-doc): Update doc type (#365)

* fix(signed-doc): log and to value

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add from doctype to vec uuid

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add more doc type

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): from doctype for vec string

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): revert

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): revert

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): backward compatible rule

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): remove unused doc type

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): improve static doc types

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): add more doc-types

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Alex Pozhylenkov <[email protected]>

* feat(rust/signed-doc): signed doc metadata serde refactoring (#372)

* impl deserialize

* refactor from_metadata_fields & remove InnerMetadata

* rename visitor

* handle aliasing

* kebab-case only deserialization for SupportedLabel

* cleanup

* fmt

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>

* fix(rust/signed-doc): Modify the `DocumentRef` structure (#355)

* fix(signed-doc): wip modify document ref

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): wip doc locator

Signed-off-by: bkioshn <[email protected]>

* fix(catalyst-types): add more derive to uuidv7

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): new doc ref structure

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): docrefs to value

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): restructure doctypes

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): format

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): linter

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): remove problem report in encoder

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): linter

Signed-off-by: bkioshn <[email protected]>

* fix(rust/signed-doc): Apply new document ref and fix validation rules (#368)

* fix(signed-doc): wip apply new doc ref

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): apply new doc ref and implement validation rule for doc ref

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): revert doc type change

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): remove problem report in encoder

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): metadata decode

Signed-off-by: bkioshn <[email protected]>

* chore(signed-doc): revert change

Signed-off-by: bkioshn <[email protected]>

* test(signed-doc): add docref to decoding test

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): format

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): refactor and improvement

Signed-off-by: bkioshn <[email protected]>

* fix(signed-doc): refactor

Signed-off-by: bkioshn <[email protected]>

* test(signed-doc): fix content test

Signed-off-by: bkioshn <[email protected]>

* test(signed-doc): fix content test

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>

---------

Signed-off-by: bkioshn <[email protected]>

* chore(rust/signed-doc): Cleanup Catalyst Signed Document `Builder`, make it type safe, add special test builder (2). (#380)

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* fix

* fix clippy

* chore(signed-doc): add problem report to doc ref (#378)

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Alex Pozhylenkov <[email protected]>

* feat(rust/signed-doc): `*_wrong_role` Catalyst Signed Documents integration tests (#381)

* more tests

* fix spelling

* test(rust/signed-doc): Add a test case for invalid params and aliases in protected header (#377)

* feat: initial test

* chore: minor cleanup

* feat: full change

* chore: fmtfix

* chore: minor lintfix

* fix: lintfix

* Update rust/signed_doc/tests/decoding.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* Update rust/signed_doc/tests/decoding.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* Update rust/signed_doc/tests/decoding.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

* fix: comments

* chore: remove signature

* chore: minor rename

* chore: minor

---------

Co-authored-by: Mr-Leshiy <[email protected]>

* feat(cat-gateway): tests for minimal valid signed docs (#384)

* test(rust/signed-doc): Add valid alias decoding as `parameters` case (#382)

* feat: initial

* chore: minor

* feat: add postcheck

* chore: minor assertion

* feat(rust/signed-doc):  Catalyst Signed Documents `minicbor::Decode` impl (#383)

* more tests

* add signatures decoding logic

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* wip

* remove coset

* fix clippy

* wip

* fix spelling

* wip

* wip

* wip

* wip

* fix comment

* wip

* add Collaborators type

* wip

* wip

* fix clippy

* fix(rust/signed-doc): Fix an issue to using original bytes for signature verification. (#386)

* add special_cbor_cases test

* wip

* fix

* wip

* fix

* add test cases

* fix comments

* Update rust/signed_doc/src/builder.rs

Co-authored-by: Artur Helmanau <[email protected]>

* add comments

* wip

* fix fmt

* fix spelling

* clippy

* fix spelling

---------

Co-authored-by: Artur Helmanau <[email protected]>

* test(rust/signed-doc): Add random header for signed doc decoding test cases (#388)

* feat: initial

* fix: content-type and content-encoding

* feat: type, id, ver

* feat: missing header case

* fix: comments

* chore: lintfix

* chore(rust/signed-doc): Provided a new `WithCborBytes` type, cleaned `InnerCatalystSignedDoc` structure and signature generation and verification process. (#391)

* add WithCborBytes new type

* update decoder

* wip

* fix clippy

* wip

* fix

* test(rust/signed-doc): Add test cases for random kid, invalid COSE tag, and case-insensitive `content_encoding` (#389)

* feat: initial

* test: add wrong cose tag case

* chore: minor name

* feat(rust/signed-doc): Add new `ContentType` variants: `Cddl` and `JsonSchema` (#392)

* feat: initial

* chore: lintfix

* feat(rust/signed-doc): Add tests for minimal and full metadata fields (#394)

* test(rust/signed-doc): add tests for minimal and full metadata fields

* fix(rust/signed-doc): spelling

* cleanup

---------

Co-authored-by: Mr-Leshiy <[email protected]>

* feat(rust/signed-doc): add test cases for valid doc type and content fields (#400)

* feat(rust/signed-doc): Add CBOR deterministic `Map` as a separate struct, enable deterministic decoding for the metadata fields. (#396)

* move decode_map_deterministically impl into separate mod, provide a dedicated type Map

* cleanup

* Fix CBOR map minimal length validation timing

Capture decoder position before d.map() call to correctly read the map
header byte instead of the first key when validating minimal encoding.

Fixes test_map_minimal_length_encoding failure.

* add `DecodeCtx` struct

* wip

* wip

* wip

* replace BtreeMap with HashMap

* fixes

---------

Co-authored-by: cong-or <[email protected]>

* feat(rust/signed-doc): Added more decoding test cases, cleaned up `DecodeContext` (#401)

* fix signed_doc_with_random_header_field_case

* add signed_doc_with_non_empty_unprotected_headers, signed_doc_with_signatures_non_empty_unprotected_headers test cases

* refactor DecodeContext

* wip

* add new test cases

* wip

* fix clippy

* refactor(rust/signed-doc): Change `collabs` header to `collaborators` (#395)

* chore: rename

* feat: cat-id decoder

* fix: minor sync

* chore: minor

* fix: bstr

* chore: b string

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>

* feat(rust/signed-doc): Invalid test cases for protected headers (#402)

* feat(rust/signed-doc): add test cases for invalid fields in metadata and signature headers

* fix(rust/signed-doc): cose signature header can only include one field

* feat(rust/signed-doc): Cleanup `DocType`, `DocumentRefs` related test cases (#406)

* remove redundant signed_doc_valid_doc_type_from_non_empty_uuid_array, signed_doc_valid_doc_type_from_uuid

* wip

* wip

* wip

* wip

* fix

* fix

* wip

* wip

* wip

* wip

* feat(rust/cbork): Add deterministically decoding array (#407)

* handle indefinite-length arrays in non-deterministic mode

* feat: indefinite test cases

* feat: verbose test cases

* chore: remove recursive tests

* chore: lintfix

* fix: comments

---------

Co-authored-by: cong-or <[email protected]>

* feat(rust/signed-doc): `Metadata::to_json` method (#410)

* add missing `to_json` method for Metadata

* fix docs

* wip

* wip

* fix spelling

* fix clippy

* feat(rust/signed-doc): Apply deterministic CBOR decoding from `cbork-utils` (#418)

* initial

* chore: minor name

* chore: lintfix

* fix: document refs 2 elements

* fix: spell

* chore: error message

* add convinient trait implementations (#423)

* feat(rust/signed-doc): Add a function to convert back `DocType` to deprecated UUID (#426)

* initial

* Update rust/signed_doc/src/metadata/doc_type.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>

* fix(rust/signed-doc): Properly export map_doc_type, to_deprecated_doc_type

* feat(rust/signed-doc): Revert back to the original `DocType` format (#434)

* wip

* wip

* wip

* Update rust/signed_doc/src/metadata/doc_type.rs

Co-authored-by: bkioshn <[email protected]>

* fix

* wip

* wip

* fix clippy

---------

Co-authored-by: bkioshn <[email protected]>

* feat(rust/signed-doc): Add `Deref` implementation for the `DocType`  (#439)

* add Deref impl for DocType

* fix

* revert using `tag` for now

* feat(rust/signed-doc): Add a function to check deprecated version below v0.04 for a signed doc (#441)

* initial

* chore: minor comment

* wip tests

* wip

* wip

* wip

* chore: minor test to check non-deterministic

* test: minor

* chore: add error doc to the function

* chore: fmtfix

---------

Co-authored-by: Mr-Leshiy <[email protected]>

* feat(rust/signed-doc): Fixing `ParametersRule` validation (#445)

* fix issue with adding problem report when everything is fine

* fix

* fix

* wip

* wip

* fix clippy

---------

Signed-off-by: bkioshn <[email protected]>
Co-authored-by: Alex Pozhylenkov <[email protected]>
Co-authored-by: Apisit Ritruengroj <[email protected]>
Co-authored-by: Artur Helmanau <[email protected]>
Co-authored-by: cong-or <[email protected]>
Co-authored-by: Joaquín Rosales <[email protected]>
Co-authored-by: Steven Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@bkioshn bkioshn Awaiting requested review from bkioshn

@cong-or cong-or Awaiting requested review from cong-or

Assignees

@no30bit no30bit

Labels
backend Task could/should be picked up as work on the backend. enhancement New feature or request review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@no30bit @Mr-Leshiy