Open
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
Re-enables syncing of Keyhive CGKA operations in the subduction_keyhive protocol, and updates the codebase to use the new keyhive_crypto crate for crypto-related traits/types.
Changes:
- Migrate crypto-related imports (
ContentRef,AsyncSigner,Signed, signing errors) fromkeyhive_coretokeyhive_cryptoand add the new dependency where needed. - Update sync event enumeration to include CGKA operations again.
- Add integration tests covering CGKA-op sync convergence.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| subduction_keyhive_policy/src/lib.rs | Switches crypto trait/type imports to keyhive_crypto. |
| subduction_keyhive_policy/Cargo.toml | Adds keyhive_crypto dependency. |
| subduction_keyhive/src/test_utils.rs | Switches MemorySigner import to keyhive_crypto. |
| subduction_keyhive/src/storage_ops.rs | Switches ContentRef/AsyncSigner bounds and imports to keyhive_crypto. |
| subduction_keyhive/src/signed_message.rs | Switches Signed import to keyhive_crypto. |
| subduction_keyhive/src/protocol.rs | Includes CGKA ops in sync event set; adds CGKA-focused sync tests. |
| subduction_keyhive/src/error.rs | Switches signing error source type to keyhive_crypto. |
| subduction_keyhive/Cargo.toml | Adds keyhive_crypto dependency. |
| Cargo.toml | Adds workspace dependency entry for keyhive_crypto (git). |
| Cargo.lock | Adds keyhive_crypto (+ transitive deps) and updates various locked versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+711
to
+718
| // CGKA ops | ||
| if let Ok(cgka_ops) = keyhive.cgka_ops_reachable_by_agent(agent).await { | ||
| ops.extend(cgka_ops.into_iter().map(|cgka_op| { | ||
| let event = Event::<Signer, T, L>::CgkaOperation(cgka_op); | ||
| let static_event: StaticEvent<T> = event.into(); | ||
| (Digest::hash(&static_event), static_event) | ||
| })); | ||
| } |
Member
Author
|
@jtfmumm any reason to not do this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.