Skip to content

Add compatibility for Python 3.12#239

Merged
ReinierKoops merged 23 commits into
mainfrom
add_compatibility_p312
Mar 18, 2024
Merged

Add compatibility for Python 3.12#239
ReinierKoops merged 23 commits into
mainfrom
add_compatibility_p312

Conversation

@ReinierKoops
Copy link
Copy Markdown
Contributor

Fixes the deprecation/renaming of SHAP code

@ReinierKoops
Copy link
Copy Markdown
Contributor Author

This should fix: #234 and #233

@ReinierKoops ReinierKoops requested a review from adri0 March 17, 2024 20:40
@ReinierKoops
Copy link
Copy Markdown
Contributor Author

@adri0 it is finally succeeded and ready for review ;)

@ReinierKoops ReinierKoops changed the title Add compatibility p312 Add compatibility for Python 3.12 Mar 17, 2024
@adri0
Copy link
Copy Markdown
Collaborator

adri0 commented Mar 18, 2024

Maybe you can add python 3.12 to the unit test matrix in the workflow.

@ReinierKoops
Copy link
Copy Markdown
Contributor Author

Maybe you can add python 3.12 to the unit test matrix in the workflow.

Nice find. I forgot! It should be added now.

@ReinierKoops ReinierKoops mentioned this pull request Mar 18, 2024
4 tasks
Copy link
Copy Markdown
Collaborator

@adri0 adri0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@ReinierKoops ReinierKoops removed the request for review from PaulZhutovsky March 18, 2024 21:41
@ReinierKoops ReinierKoops merged commit 75a0ab0 into main Mar 18, 2024
ReinierKoops pushed a commit to ReinierKoops/probatus that referenced this pull request Mar 26, 2024
Fixes the deprecation/renaming of SHAP code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants