Skip to content

Use rfc3339 as default timestamp precision #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

swr1bm86
Copy link
Contributor

According to https://docs.influxdata.com/influxdb/v1.7/tools/shell/#precision-rfc3339-h-m-s-ms-u-ns, we should use rfc3339 instead of empty string as the default timestamp precision

Checklist

  • Formatted code using cargo fmt --all
  • Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • Updated README.md using cargo readme > README.md
  • Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

…ecision

According to https://docs.influxdata.com/influxdb/v1.7/tools/shell/#precision-rfc3339-h-m-s-ms-u-ns,
we should use rfc3339 instead of empty string as the default timestamp precision
Copy link
Collaborator

@Empty2k12 Empty2k12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for finding and fixing this. Much appreciated!

@Empty2k12 Empty2k12 changed the title improvement(timestamp/precision): use rfc3339 as default timestamp precision Use rfc3339 as default timestamp precision Feb 20, 2020
@Empty2k12 Empty2k12 merged commit 789b388 into influxdb-rs:master Feb 20, 2020
@Empty2k12 Empty2k12 mentioned this pull request Aug 21, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants