Closed
Conversation
Contributor
Author
|
I may add the ability to parse http headers in the format: ''' |
Contributor
Author
|
That should be enough input for what I need. |
Contributor
|
Thanks for the contribution @lswith, but instead of a standalone plugin, do you think you could add this to the |
Contributor
|
although the addition of headers may make that difficult |
Contributor
Author
|
I thought about it and I feel like this is too different to it. Yes they both track response time, however an http request is quite different to a tcp connection. |
Contributor
|
sure, I think actually it's OK to leave as separate |
| headers = ''' | ||
| Host: github.com | ||
| ''' | ||
| ## Whether to follow redirects from the server (defaults to false) |
Contributor
There was a problem hiding this comment.
these should be indented by two spaces, not tabs
Contributor
|
overall this looks good, but you'll need to write unit tests. |
Contributor
Author
|
will do. |
Contributor
Author
|
Tests are complete. Waiting on you guys |
| ## Server address (default http://localhost) | ||
| address = "http://github.com" | ||
| ## Set response_timeout (default 10 seconds) | ||
| response_timeout = 10 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves issue #332