Allow jobs with dashes in the name by changing job marker.#6313
Merged
danielnelson merged 1 commit intoinfluxdata:masterfrom Aug 27, 2019
Merged
Allow jobs with dashes in the name by changing job marker.#6313danielnelson merged 1 commit intoinfluxdata:masterfrom
danielnelson merged 1 commit intoinfluxdata:masterfrom
Conversation
glinton
approved these changes
Aug 26, 2019
Contributor
glinton
left a comment
glinton
left a comment
There was a problem hiding this comment.
Looks good, adding a space to the Split scared me at first, but I see in the tests that we are already testing full functionality.
danielnelson
pushed a commit
that referenced
this pull request
Aug 27, 2019
(cherry picked from commit 17a79e2)
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Seems like a bugfix, so not sure what would need to be changed in the README.md
Currently, jobs with a dash in the jobid aren't captured correctly.